Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1750963002: Update demo with features from support lib 23.2.0 (Closed)

Created:
4 years, 9 months ago by andreban
Modified:
4 years, 9 months ago
Reviewers:
pasko
Base URL:
https://chromium.googlesource.com/external/github.com/GoogleChrome/custom-tabs-client@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update demo with features from support lib 23.2.0 - Added demo for default share menu action - Added demo secondary toolbar color change - Added demo toolbar button BUG= Committed: https://github.com/GoogleChrome/custom-tabs-client/commit/30e16577e696b635bfc5f66aafadc8a8033b8082

Patch Set 1 #

Total comments: 4

Patch Set 2 : Improved comment on decoding Bitmap on UI thread #

Patch Set 3 : Fix comment on decoding Bitmpa on UI thread #

Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -185 lines) Patch
M demos/build.gradle View 2 chunks +5 lines, -5 lines 0 comments Download
M demos/src/main/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
A demos/src/main/java/org/chromium/customtabsdemos/ActionBroadcastReceiver.java View 1 1 chunk +54 lines, -0 lines 0 comments Download
M demos/src/main/java/org/chromium/customtabsdemos/CustomTabActivityHelper.java View 2 chunks +0 lines, -3 lines 0 comments Download
M demos/src/main/java/org/chromium/customtabsdemos/CustomUIActivity.java View 1 2 4 chunks +48 lines, -14 lines 0 comments Download
D demos/src/main/java/org/chromium/customtabsdemos/ShareBroadcastReceiver.java View 1 chunk +0 lines, -41 lines 0 comments Download
M demos/src/main/res/layout/activity_custom_ui.xml View 1 chunk +180 lines, -115 lines 0 comments Download
M demos/src/main/res/layout/activity_main.xml View 1 chunk +1 line, -1 line 0 comments Download
M demos/src/main/res/layout/item_example_description.xml View 1 chunk +1 line, -1 line 0 comments Download
M demos/src/main/res/values/strings.xml View 2 chunks +8 lines, -1 line 0 comments Download
M shared/build.gradle View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
pasko
lgtm, thank you https://codereview.chromium.org/1750963002/diff/1/demos/src/main/java/org/chromium/customtabsdemos/ActionBroadcastReceiver.java File demos/src/main/java/org/chromium/customtabsdemos/ActionBroadcastReceiver.java (right): https://codereview.chromium.org/1750963002/diff/1/demos/src/main/java/org/chromium/customtabsdemos/ActionBroadcastReceiver.java#newcode36 demos/src/main/java/org/chromium/customtabsdemos/ActionBroadcastReceiver.java:36: String toastText = getToastText(context, intent.getIntExtra(KEY_ACTION_SOURCE, -1), ...
4 years, 9 months ago (2016-03-01 14:28:28 UTC) #3
andreban
Addressed the comments https://codereview.chromium.org/1750963002/diff/1/demos/src/main/java/org/chromium/customtabsdemos/ActionBroadcastReceiver.java File demos/src/main/java/org/chromium/customtabsdemos/ActionBroadcastReceiver.java (right): https://codereview.chromium.org/1750963002/diff/1/demos/src/main/java/org/chromium/customtabsdemos/ActionBroadcastReceiver.java#newcode36 demos/src/main/java/org/chromium/customtabsdemos/ActionBroadcastReceiver.java:36: String toastText = getToastText(context, intent.getIntExtra(KEY_ACTION_SOURCE, -1), ...
4 years, 9 months ago (2016-03-01 15:03:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750963002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750963002/40001
4 years, 9 months ago (2016-03-01 15:28:40 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 15:30:15 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/GoogleChrome/custom-tabs-client/commit/30e16577e696b635bfc...

Powered by Google App Engine
This is Rietveld 408576698