Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 1750893003: Convert LoadTimeExtension to gin::Wrappable (Closed)

Created:
4 years, 9 months ago by meacer
Modified:
4 years, 3 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert LoadTimeExtension to gin::Wrappable BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -183 lines) Patch
M chrome/renderer/chrome_content_renderer_client.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/loadtimes_extension_bindings.h View 1 chunk +41 lines, -4 lines 0 comments Download
M chrome/renderer/loadtimes_extension_bindings.cc View 2 chunks +178 lines, -178 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
meacer
jochen, can you PTAL? This adds the properties under chrome.loadTimesController instead of just chrome. I ...
4 years, 9 months ago (2016-03-02 00:37:39 UTC) #2
jochen (gone - plz use gerrit)
thanks for doing this I didn't realize that we expose this to all websites, and ...
4 years, 9 months ago (2016-03-02 11:00:45 UTC) #4
haraken
On 2016/03/02 11:00:45, jochen wrote: > thanks for doing this > > I didn't realize ...
4 years, 9 months ago (2016-03-02 13:37:21 UTC) #5
esprehn
On 2016/03/02 at 13:37:21, haraken wrote: > On 2016/03/02 11:00:45, jochen wrote: > > thanks ...
4 years, 9 months ago (2016-03-02 17:20:15 UTC) #6
meacer
4 years, 9 months ago (2016-03-09 21:56:40 UTC) #7
On 2016/03/02 17:20:15, esprehn wrote:
> On 2016/03/02 at 13:37:21, haraken wrote:
> > On 2016/03/02 11:00:45, jochen wrote:
> > > thanks for doing this
> > > 
> > > I didn't realize that we expose this to all websites, and not just when a
> > > certain command line flag is set.
> > > 
> > > I'd rather have this as an IDL defined Web API in Chrome. Elliot/Kentaro,
> what
> > > do you think?
> > 
> > +1. I'm a fan of describing all web-exposed features in IDL files.
> 
> Yeah let's move this into blink.

Tracking at crbug.com/593476 now

Powered by Google App Engine
This is Rietveld 408576698