Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8014)

Unified Diff: components/offline_pages/offline_page_model_unittest.cc

Issue 1750883002: Add enable-offlining-recent-pages feature switch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated histogram.xml Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model_unittest.cc
diff --git a/components/offline_pages/offline_page_model_unittest.cc b/components/offline_pages/offline_page_model_unittest.cc
index 253dc67da9e427671da31095bbe886f1f17cad82..b3bc692eb12070157b0fd069437b2a643c2e9984 100644
--- a/components/offline_pages/offline_page_model_unittest.cc
+++ b/components/offline_pages/offline_page_model_unittest.cc
@@ -9,6 +9,7 @@
#include <utility>
#include "base/bind.h"
+#include "base/command_line.h"
#include "base/files/file_util.h"
#include "base/files/scoped_temp_dir.h"
#include "base/run_loop.h"
@@ -24,7 +25,9 @@
#include "components/bookmarks/browser/bookmark_undo_delegate.h"
#include "components/bookmarks/browser/bookmark_undo_provider.h"
#include "components/bookmarks/test/test_bookmark_client.h"
+#include "components/offline_pages/offline_page_feature.h"
#include "components/offline_pages/offline_page_item.h"
+#include "components/offline_pages/offline_page_switches.h"
#include "components/offline_pages/offline_page_test_archiver.h"
#include "components/offline_pages/offline_page_test_store.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -917,4 +920,19 @@ TEST_F(OfflinePageModelBookmarkChangeTest, UndoBookmarkRemoval) {
EXPECT_EQ(1UL, model()->GetAllPages().size());
}
+TEST(CommandLineFlagsTest, OffliningRecentPages) {
+ // TODO(dimich): once offline pages are enabled by default, remove this.
+ base::CommandLine::ForCurrentProcess()->AppendSwitch(
+ switches::kEnableOfflinePages);
+
+ // Disabled by default.
+ EXPECT_FALSE(IsOffliningRecentPagesEnabled());
+ base::CommandLine::ForCurrentProcess()->AppendSwitch(
+ switches::kEnableOffliningRecentPages);
+ EXPECT_TRUE(IsOffliningRecentPagesEnabled());
+ base::CommandLine::ForCurrentProcess()->AppendSwitch(
+ switches::kDisableOffliningRecentPages);
+ EXPECT_FALSE(IsOffliningRecentPagesEnabled());
+}
+
} // namespace offline_pages

Powered by Google App Engine
This is Rietveld 408576698