Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: chrome/browser/about_flags.cc

Issue 1750883002: Add enable-offlining-recent-pages feature switch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: build break Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 6ec41ea83f5d8f4fe215c2ceac46b19f682c4455..bd69953fd44efbca9a3101b41fc7680865869493 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -43,6 +43,7 @@
#include "components/flags_ui/flags_storage.h"
#include "components/flags_ui/flags_ui_switches.h"
#include "components/nacl/common/nacl_switches.h"
+#include "components/offline_pages/offline_page_feature.h"
#include "components/offline_pages/offline_page_switches.h"
#include "components/omnibox/browser/omnibox_switches.h"
#include "components/password_manager/core/common/password_manager_features.h"
@@ -1799,6 +1800,12 @@ const FeatureEntry kFeatureEntries[] = {
ENABLE_DISABLE_VALUE_TYPE(switches::kEnableImeThread,
switches::kDisableImeThread)},
#endif // defined(OS_ANDROID)
+#if defined(OS_ANDROID)
+ {"offlining-recent-pages", IDS_FLAGS_OFFLINING_RECENT_PAGES_NAME,
jianli 2016/03/08 00:48:57 Do we still need this?
Dmitry Titov 2016/03/08 01:08:24 I think so - that's what creates the entries in ch
+ IDS_FLAGS_OFFLINING_RECENT_PAGES_DESCRIPTION, kOsAndroid,
+ FEATURE_VALUE_TYPE(offline_pages::kOffliningRecentPagesFeature)},
+#endif // defined(OS_ANDROID)
+
// NOTE: Adding new command-line switches requires adding corresponding
// entries to enum "LoginCustomFlags" in histograms.xml. See note in
// histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.

Powered by Google App Engine
This is Rietveld 408576698