Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 1750883002: Add enable-offlining-recent-pages feature switch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated histogram.xml Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 1803 matching lines...) Expand 10 before | Expand all | Expand 10 after
1814 {"enable-ntp-snippets", IDS_FLAGS_ENABLE_NTP_SNIPPETS_NAME, 1814 {"enable-ntp-snippets", IDS_FLAGS_ENABLE_NTP_SNIPPETS_NAME,
1815 IDS_FLAGS_ENABLE_NTP_SNIPPETS_DESCRIPTION, kOsAndroid, 1815 IDS_FLAGS_ENABLE_NTP_SNIPPETS_DESCRIPTION, kOsAndroid,
1816 FEATURE_VALUE_TYPE(chrome::android::kNTPSnippetsFeature)}, 1816 FEATURE_VALUE_TYPE(chrome::android::kNTPSnippetsFeature)},
1817 #endif // defined(OS_ANDROID) 1817 #endif // defined(OS_ANDROID)
1818 #if defined(OS_ANDROID) 1818 #if defined(OS_ANDROID)
1819 {"ime-thread", IDS_FLAGS_IME_THREAD_NAME, 1819 {"ime-thread", IDS_FLAGS_IME_THREAD_NAME,
1820 IDS_FLAGS_IME_THREAD_DESCRIPTION, kOsAndroid, 1820 IDS_FLAGS_IME_THREAD_DESCRIPTION, kOsAndroid,
1821 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableImeThread, 1821 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableImeThread,
1822 switches::kDisableImeThread)}, 1822 switches::kDisableImeThread)},
1823 #endif // defined(OS_ANDROID) 1823 #endif // defined(OS_ANDROID)
1824 #if defined(OS_ANDROID)
1825 {"offlining-recent-pages", IDS_FLAGS_OFFLINING_RECENT_PAGES_NAME,
1826 IDS_FLAGS_OFFLINING_RECENT_PAGES_DESCRIPTION, kOsAndroid,
1827 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableOffliningRecentPages,
1828 switches::kDisableOffliningRecentPages)},
1829 #endif // defined(OS_ANDROID)
1830
1824 // NOTE: Adding new command-line switches requires adding corresponding 1831 // NOTE: Adding new command-line switches requires adding corresponding
1825 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 1832 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
1826 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 1833 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
1827 }; 1834 };
1828 1835
1829 class FlagsStateSingleton { 1836 class FlagsStateSingleton {
1830 public: 1837 public:
1831 FlagsStateSingleton() 1838 FlagsStateSingleton()
1832 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {} 1839 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {}
1833 ~FlagsStateSingleton() {} 1840 ~FlagsStateSingleton() {}
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
2035 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2042 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2036 2043
2037 const FeatureEntry* GetFeatureEntries(size_t* count) { 2044 const FeatureEntry* GetFeatureEntries(size_t* count) {
2038 *count = arraysize(kFeatureEntries); 2045 *count = arraysize(kFeatureEntries);
2039 return kFeatureEntries; 2046 return kFeatureEntries;
2040 } 2047 }
2041 2048
2042 } // namespace testing 2049 } // namespace testing
2043 2050
2044 } // namespace about_flags 2051 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698