Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.js

Issue 1750873002: [MD settings] change ClearBrowsingData from a sub-page to a dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review nits Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.js
diff --git a/chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.js b/chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.js
index d5c56c6c8b00bc046fe07d30ec5890f54dc54aa8..5971300dcdd3aec525f562414cdf913ba2c05a95 100644
--- a/chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.js
+++ b/chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.js
@@ -72,8 +72,7 @@ Polymer({
/** @private */
doneClearing_: function() {
- if (this.$)
- this.$.clearDataButton.disabled = false;
+ // TODO(dschuyler): inform the user on whether clearing data was successful.
},
/**
@@ -92,9 +91,16 @@ Polymer({
}
},
- /** @private */
- onPerformClearBrowsingDataTap_: function() {
- this.$.clearDataButton.disabled = true;
- chrome.send('performClearBrowserData');
+ showClearBrowsingDataDialog: function() {
+ this.$.clearBrowsingDataDialog.open();
+ },
+
+ /**
+ * @param {!Event} event Tells us whether to perform an action or cancel.
+ * @private
+ */
+ onDialogClosed_: function(event) {
+ if (event.detail.confirmed)
+ chrome.send('performClearBrowserData');
},
});

Powered by Google App Engine
This is Rietveld 408576698