Chromium Code Reviews Chromium Code Reviews
Issue 1750873002:
[MD settings] change ClearBrowsingData from a sub-page to a dialog (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 // Copyright 2015 The Chromium Authors. All rights reserved. | 1 // Copyright 2015 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 /** | 5 /** |
| 6 * @fileoverview | 6 * @fileoverview |
| 7 * 'settings-privacy-page' is the settings page containing privacy and | 7 * 'settings-privacy-page' is the settings page containing privacy and |
| 8 * security settings. | 8 * security settings. |
| 9 * | 9 * |
| 10 * Example: | 10 * Example: |
| (...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 48 this.$.pages.setSubpageChain(['manage-certificates']); | 48 this.$.pages.setSubpageChain(['manage-certificates']); |
| 49 }, | 49 }, |
| 50 | 50 |
| 51 /** @private */ | 51 /** @private */ |
| 52 onSiteSettingsTap_: function() { | 52 onSiteSettingsTap_: function() { |
| 53 this.$.pages.setSubpageChain(['site-settings']); | 53 this.$.pages.setSubpageChain(['site-settings']); |
| 54 }, | 54 }, |
| 55 | 55 |
| 56 /** @private */ | 56 /** @private */ |
| 57 onClearBrowsingDataTap_: function() { | 57 onClearBrowsingDataTap_: function() { |
| 58 this.$.pages.setSubpageChain(['clear-browsing-data']); | 58 this.$.pages.querySelector('settings-clear-browsing-data-page').$ |
| 59 .clearBrowsingDataDialog.open(); | |
|
michaelpg
2016/03/02 23:19:37
eek, can we add a public function instead of using
dschuyler
2016/03/03 02:05:03
Done.
| |
| 59 }, | 60 }, |
| 60 }); | 61 }); |
| OLD | NEW |
