Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/browser/resources/settings/privacy_page/privacy_page.js

Issue 1750873002: [MD settings] change ClearBrowsingData from a sub-page to a dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review nits Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/settings/privacy_page/privacy_page.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-privacy-page' is the settings page containing privacy and 7 * 'settings-privacy-page' is the settings page containing privacy and
8 * security settings. 8 * security settings.
9 * 9 *
10 * Example: 10 * Example:
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 this.$.pages.setSubpageChain(['manage-certificates']); 45 this.$.pages.setSubpageChain(['manage-certificates']);
46 }, 46 },
47 47
48 /** @private */ 48 /** @private */
49 onSiteSettingsTap_: function() { 49 onSiteSettingsTap_: function() {
50 this.$.pages.setSubpageChain(['site-settings']); 50 this.$.pages.setSubpageChain(['site-settings']);
51 }, 51 },
52 52
53 /** @private */ 53 /** @private */
54 onClearBrowsingDataTap_: function() { 54 onClearBrowsingDataTap_: function() {
55 this.$.pages.setSubpageChain(['clear-browsing-data']); 55 this.$.pages.querySelector('settings-clear-browsing-data-page')
56 .showClearBrowsingDataDialog();
56 }, 57 },
57 }); 58 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/settings/privacy_page/privacy_page.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698