Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Side by Side Diff: content/renderer/render_frame_impl.cc

Issue 1750863002: Revert of Separate RenderView from RenderWidget, part 1: inheritance. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@renderwidgettest
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_frame_impl.h" 5 #include "content/renderer/render_frame_impl.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 807 matching lines...) Expand 10 before | Expand all | Expand 10 after
818 WebLocalFrame* web_frame = 818 WebLocalFrame* web_frame =
819 WebLocalFrame::create(blink::WebTreeScopeType::Document, render_frame); 819 WebLocalFrame::create(blink::WebTreeScopeType::Document, render_frame);
820 render_frame->BindToWebFrame(web_frame); 820 render_frame->BindToWebFrame(web_frame);
821 render_view->webview()->setMainFrame(web_frame); 821 render_view->webview()->setMainFrame(web_frame);
822 render_frame->render_widget_ = RenderWidget::CreateForFrame( 822 render_frame->render_widget_ = RenderWidget::CreateForFrame(
823 widget_routing_id, hidden, screen_info, compositor_deps, web_frame); 823 widget_routing_id, hidden, screen_info, compositor_deps, web_frame);
824 // TODO(kenrb): Observing shouldn't be necessary when we sort out 824 // TODO(kenrb): Observing shouldn't be necessary when we sort out
825 // WasShown and WasHidden, separating page-level visibility from 825 // WasShown and WasHidden, separating page-level visibility from
826 // frame-level visibility. 826 // frame-level visibility.
827 // TODO(avi): This DCHECK is to track cleanup for https://crbug.com/545684 827 // TODO(avi): This DCHECK is to track cleanup for https://crbug.com/545684
828 DCHECK_EQ(render_view->GetWidget(), render_frame->render_widget_) 828 DCHECK_EQ(render_view, render_frame->render_widget_)
829 << "Main frame is no longer reusing the RenderView as its widget! " 829 << "Main frame is no longer reusing the RenderView as its widget! "
830 << "Does the RenderFrame need to register itself with the RenderWidget?"; 830 << "Does the RenderFrame need to register itself with the RenderWidget?";
831 return render_frame; 831 return render_frame;
832 } 832 }
833 833
834 // static 834 // static
835 void RenderFrameImpl::CreateFrame( 835 void RenderFrameImpl::CreateFrame(
836 int routing_id, 836 int routing_id,
837 int proxy_routing_id, 837 int proxy_routing_id,
838 int opener_routing_id, 838 int opener_routing_id,
(...skipping 5230 matching lines...) Expand 10 before | Expand all | Expand 10 after
6069 int match_count, 6069 int match_count,
6070 int ordinal, 6070 int ordinal,
6071 const WebRect& selection_rect, 6071 const WebRect& selection_rect,
6072 bool final_status_update) { 6072 bool final_status_update) {
6073 Send(new FrameHostMsg_Find_Reply(routing_id_, request_id, match_count, 6073 Send(new FrameHostMsg_Find_Reply(routing_id_, request_id, match_count,
6074 selection_rect, ordinal, 6074 selection_rect, ordinal,
6075 final_status_update)); 6075 final_status_update));
6076 } 6076 }
6077 6077
6078 } // namespace content 6078 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/pepper/pepper_file_chooser_host_unittest.cc ('k') | content/renderer/render_frame_impl_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698