scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_device.json - Issue 1750853005: Skia bots: use deps_os = 'all'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_device.json

Issue 1750853005: Skia bots: use deps_os = 'all' (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Use "all" Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/skia/skia.expected/has_ccache_android.json ('k') | scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_host.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_device.json

diff --git a/scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_device.json b/scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_device.json

index 8efb9f8b6384dc54021e0453769c6f780586aaba..262e631b4b44b2f6e0178673b85ec88b034bd584 100644

--- a/scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_device.json

+++ b/scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_device.json

@@ -34,7 +34,7 @@

"RECIPE_PACKAGE[depot_tools]/gclient.py",

"config",

"--spec",

- "cache_dir = None\nsolutions = [{'deps_file': 'DEPS', 'managed': True, 'name': 'skia', 'url': 'https://skia.googlesource.com/skia.git'}]"

+ "cache_dir = None\ndeps_os = {'skia': 'all'}\nsolutions = [{'deps_file': 'DEPS', 'managed': True, 'name': 'skia', 'url': 'https://skia.googlesource.com/skia.git'}]"

"cwd": "[SLAVE_BUILD]",

"env": {