Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1750853002:
Refresh Public Suffic List to the latest version (Closed)
|
Created:
4 years, 9 months ago by Ryan Sleevi Modified:
4 years, 9 months ago Reviewers:
Peter Kasting CC:
chromium-reviews, cbentzel+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRefresh Public Suffic List to the latest version
This updates from revision
3594dcfbd8cf1cb3ba2c57bd56b761147ea31fca (2016-01-04)
to revision
fa6e6592cd76eb0cf6d442dbebe24f0a22787c6e (2016-03-01)
R=pkasting@chromium.org
BUG=37436
Committed: https://crrev.com/7764d74d70161b6f16ebe055c901098ea55ce50c
Cr-Commit-Position: refs/heads/master@{#381606}
Patch Set 1 #
Total comments: 5
Messages
Total messages: 25 (10 generated)
Peter: Ended up missing the M-49 window, but this would be good for M50 This is a *big* diff because 1) PSL maintainers agreed to stop including the dates of authorization in the CLs; instead, we're just keeping a list of parties authorized to make changes. 2) HTTPS all the things happened 3) Let's Encrypt's availability has seen a lot more parties wanting to get on the PSL (... and they arguably should have been in the first place) The number of new gTLDs is relatively low, but a few large web operators expanded zones. Wildcards (and double wildcards) have been shown to have buggy affect on a number of implementations, so that's why we haven't gone whole hog on embracing them to reduce churn.
LGTM https://codereview.chromium.org/1750853002/diff/1/net/base/registry_controlle... File net/base/registry_controlled_domains/effective_tld_names.dat (left): https://codereview.chromium.org/1750853002/diff/1/net/base/registry_controlle... net/base/registry_controlled_domains/effective_tld_names.dat:491: // Submitted by registry <jarle@uninett.no> 2006-06-16 Sigh. Personally I find removing these dates a loss; the dates came in useful for me several times in the past. It's frustrating that I have absolutely no power or influence and thus my only response to a change like this can be to just rubber-stamp it. https://codereview.chromium.org/1750853002/diff/1/net/base/registry_controlle... net/base/registry_controlled_domains/effective_tld_names.dat:7825: What happened to this?
https://codereview.chromium.org/1750853002/diff/1/net/base/registry_controlle... File net/base/registry_controlled_domains/effective_tld_names.dat (left): https://codereview.chromium.org/1750853002/diff/1/net/base/registry_controlle... net/base/registry_controlled_domains/effective_tld_names.dat:491: // Submitted by registry <jarle@uninett.no> 2006-06-16 On 2016/03/01 08:50:30, Peter Kasting wrote: > Sigh. Personally I find removing these dates a loss; the dates came in useful > for me several times in the past. Can you explain why? The GitHub blame tool works just fine for this. > It's frustrating that I have absolutely no power or influence and thus my only > response to a change like this can be to just rubber-stamp it. That's not true; if you feel there are things worth changing, it's only a GitHub away. We've also been trying to keep discussions on the Issues List for things like this. For example, this change was discussed at https://github.com/publicsuffix/list/issues/109 https://codereview.chromium.org/1750853002/diff/1/net/base/registry_controlle... net/base/registry_controlled_domains/effective_tld_names.dat:7825: On 2016/03/01 08:50:30, Peter Kasting wrote: > What happened to this? The Registry decided they didn't want to be a registry anymore. "Thanks ICANN" http://domainincite.com/19410-first-dot-brand-gtld-calls-it-quits http://www.brandregistrygroup.org/first-new-gtld-deleted-from-the-net/
The CQ bit was checked by rsleevi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750853002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
https://codereview.chromium.org/1750853002/diff/1/net/base/registry_controlle... File net/base/registry_controlled_domains/effective_tld_names.dat (left): https://codereview.chromium.org/1750853002/diff/1/net/base/registry_controlle... net/base/registry_controlled_domains/effective_tld_names.dat:491: // Submitted by registry <jarle@uninett.no> 2006-06-16 On 2016/03/01 15:54:12, Ryan Sleevi wrote: > On 2016/03/01 08:50:30, Peter Kasting wrote: > > Sigh. Personally I find removing these dates a loss; the dates came in useful > > for me several times in the past. > > Can you explain why? The GitHub blame tool works just fine for this. I don't know about how the list is managed now, but at least in the past, external submissions often took significant time (weeks or months) before being processed, and sometimes there were changes in the meantime. The date was the date of the original submission rather than the date of inclusion in the list, which was important when looking later to see what the time period was over which anything might have changed. (And of course there's the way that by removing these dates, git blame just became that much more annoying to try to navigate through.) I found the date much more useful than the name, FWIW.
The CQ bit was checked by rsleevi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750853002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rsleevi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750853002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rsleevi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750853002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rsleevi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750853002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Refresh Public Suffic List to the latest version This updates from revision 3594dcfbd8cf1cb3ba2c57bd56b761147ea31fca (2016-01-04) to revision fa6e6592cd76eb0cf6d442dbebe24f0a22787c6e (2016-03-01) R=pkasting@chromium.org BUG=37436 ========== to ========== Refresh Public Suffic List to the latest version This updates from revision 3594dcfbd8cf1cb3ba2c57bd56b761147ea31fca (2016-01-04) to revision fa6e6592cd76eb0cf6d442dbebe24f0a22787c6e (2016-03-01) R=pkasting@chromium.org BUG=37436 Committed: https://crrev.com/7764d74d70161b6f16ebe055c901098ea55ce50c Cr-Commit-Position: refs/heads/master@{#381606} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/7764d74d70161b6f16ebe055c901098ea55ce50c Cr-Commit-Position: refs/heads/master@{#381606} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
