Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 9 months ago by hiroshige Modified:
4 years, 9 months ago Reviewers:
Yoav Weiss CC:
chromium-reviews, tyoshino+watch_chromium.org, gavinp+prerender_chromium.org, Yoav Weiss, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, Nate Chapin Base URL:
https://chromium.googlesource.com/chromium/src.git@SVG_2_FontResource Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse http:// instead of data:// in LinkLoaderTest.Preload
The test uses invalid data:// URLs, but handling of invalid data:// URLs will
be changed by Issue 382170, which breaks the test.
This CL replaces data:// URLs with http:// URLs with mocks.
BUG=382170
Committed: https://crrev.com/ddc87373c87a56fb280c277fdef28e2c9646496a
Cr-Commit-Position: refs/heads/master@{#380807}
Patch Set 1 #Patch Set 2 : Rebase. #Patch Set 3 : Rebase. #Patch Set 4 : Rebase. #
Created: 4 years, 9 months ago
Dependent Patchsets: Messages
Total messages: 41 (23 generated)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Description was changed from ========== Use http:// instead of data: in LinkLoaderTest BUG=382170 ========== to ========== Use http:// instead of data: in LinkLoaderTest BUG=382170 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750843002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750843002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Use http:// instead of data: in LinkLoaderTest BUG=382170 ========== to ========== Use http:// instead of data:// in LinkLoaderTest.Preload The test uses invalid data:// URLs, but handling of invalid data:// URLs will be changed by Issue 382170, which breaks the test. This CL replaces data:// URLs with http:// URLs with mocks. BUG=382170 ==========
hiroshige@chromium.org changed reviewers: + yoav@yoav.ws
Could you take a look?
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750843002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750843002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #2 (id:20001) has been deleted
Patchset #2 (id:40001) has been deleted
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750843002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750843002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM. Apologies for the late review, I was traveling and must've missed the related email. Please ping me in the future if I fail to review code within 2-3 days.
The CQ bit was checked by hiroshige@chromium.org
The CQ bit was unchecked by hiroshige@chromium.org
The CQ bit was checked by hiroshige@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750843002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750843002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750843002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750843002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Thanks for reviewing!
The CQ bit was checked by hiroshige@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yoav@yoav.ws Link to the patchset: https://codereview.chromium.org/1750843002/#ps100001 (title: "Rebase.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750843002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750843002/100001
Message was sent while issue was closed.
Description was changed from ========== Use http:// instead of data:// in LinkLoaderTest.Preload The test uses invalid data:// URLs, but handling of invalid data:// URLs will be changed by Issue 382170, which breaks the test. This CL replaces data:// URLs with http:// URLs with mocks. BUG=382170 ========== to ========== Use http:// instead of data:// in LinkLoaderTest.Preload The test uses invalid data:// URLs, but handling of invalid data:// URLs will be changed by Issue 382170, which breaks the test. This CL replaces data:// URLs with http:// URLs with mocks. BUG=382170 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Use http:// instead of data:// in LinkLoaderTest.Preload The test uses invalid data:// URLs, but handling of invalid data:// URLs will be changed by Issue 382170, which breaks the test. This CL replaces data:// URLs with http:// URLs with mocks. BUG=382170 ========== to ========== Use http:// instead of data:// in LinkLoaderTest.Preload The test uses invalid data:// URLs, but handling of invalid data:// URLs will be changed by Issue 382170, which breaks the test. This CL replaces data:// URLs with http:// URLs with mocks. BUG=382170 Committed: https://crrev.com/ddc87373c87a56fb280c277fdef28e2c9646496a Cr-Commit-Position: refs/heads/master@{#380807} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/ddc87373c87a56fb280c277fdef28e2c9646496a Cr-Commit-Position: refs/heads/master@{#380807} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
