Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1750823002: Fix missing dependency on Android gyp builds with mojo. (Closed)

Created:
4 years, 9 months ago by jam
Modified:
4 years, 9 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix missing dependency on Android gyp builds with mojo. I hit this when building locally to reproduce another build error: In file included from ../../content/browser/frame_host/frame_tree_node.h:16:0, from ../../content/test/content_browser_test_utils_internal.cc:22: ../../content/browser/frame_host/render_frame_host_impl.h:34:68: fatal error: content/common/image_downloader/image_downloader.mojom.h: No such file or directory #include "content/common/image_downloader/image_downloader.mojom.h" The problem is that content_browser_test_support target, which depends includes content_browser_test_utils_internal.cc, doesn't depend on content_browser on Android. It instead depends on content_app_both. content_app.gypi only had a direct dependency on the bindings, but needs an export dependency as well. Committed: https://crrev.com/284d12c2bb76b632ee7e3e43f76e33f64adfa0ee Cr-Commit-Position: refs/heads/master@{#378407}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/content_app.gypi View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
jam
4 years, 9 months ago (2016-03-01 00:32:02 UTC) #3
yzshen1
lgtm
4 years, 9 months ago (2016-03-01 00:40:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750823002/1
4 years, 9 months ago (2016-03-01 06:11:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 06:36:44 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 06:38:04 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/284d12c2bb76b632ee7e3e43f76e33f64adfa0ee
Cr-Commit-Position: refs/heads/master@{#378407}

Powered by Google App Engine
This is Rietveld 408576698