tools/dom/templates/html/impl/impl_RTCPeerConnection.darttemplate - Issue 17508002: Revert "Making all DOM types abstract and removing superfluous Dartium constructors."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/templates/html/impl/impl_RTCPeerConnection.darttemplate

Issue 17508002: Revert "Making all DOM types abstract and removing superfluous Dartium constructors." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/dom/templates/html/impl/impl_Notification.darttemplate ('k') | tools/dom/templates/html/impl/impl_RadioNodeList.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/dom/templates/html/impl/impl_RTCPeerConnection.darttemplate

diff --git a/tools/dom/templates/html/impl/impl_RTCPeerConnection.darttemplate b/tools/dom/templates/html/impl/impl_RTCPeerConnection.darttemplate

index 13e2b0af3a9f3f5c8f8afcde42c911b9a02451cd..1184bd0d5e71942be4f636d4ef155e2123766466 100644

--- a/tools/dom/templates/html/impl/impl_RTCPeerConnection.darttemplate

+++ b/tools/dom/templates/html/impl/impl_RTCPeerConnection.darttemplate

@@ -4,7 +4,7 @@

part of $LIBRARYNAME;

-$(ANNOTATIONS)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {

+$(ANNOTATIONS)class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {

$if DART2JS

factory $CLASSNAME(Map rtcIceServers, [Map mediaConstraints]) {

var constructorName = JS('RtcPeerConnection', 'window[#]',

@@ -29,7 +29,7 @@ $if DART2JS

// Currently in Firefox some of the RTC elements are defined but throw an

// error unless the user has specifically enabled them in their

// about:config. So we have to construct an element to actually test if RTC

- // is supported at the given time.

+ // is supported at the given time.

try {

new RtcPeerConnection(

{"iceServers": [ {"url":"stun:localhost"}]});