Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Unified Diff: sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart

Issue 17508002: Revert "Making all DOM types abstract and removing superfluous Dartium constructors." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/html/dartium/nativewrappers.dart ('k') | sdk/lib/indexed_db/dartium/indexed_db_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart
diff --git a/sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart b/sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart
index 1961500969fe1aaadcb76e4f88953bc9e3d5cf8b..9dd0d9a6f6a4810a54abfb6379801cd2095a1dc7 100644
--- a/sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart
+++ b/sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart
@@ -158,9 +158,7 @@ class Cursor native "IDBCursor" {
}
}
- // To suppress missing implicit constructor warnings.
- factory Cursor._() { throw new UnsupportedError("Not supported"); }
-
+
@DomName('IDBCursor.direction')
@DocsEditable
final String direction;
@@ -218,8 +216,6 @@ class Cursor native "IDBCursor" {
@DomName('IDBCursorWithValue')
@Unstable
class CursorWithValue extends Cursor native "IDBCursorWithValue" {
- // To suppress missing implicit constructor warnings.
- factory CursorWithValue._() { throw new UnsupportedError("Not supported"); }
dynamic get value => _convertNativeToDart_IDBAny(this._get_value);
@JSName('value')
@@ -274,8 +270,6 @@ class Database extends EventTarget native "IDBDatabase" {
@JSName('transaction')
Transaction _transaction(stores, mode) native;
- // To suppress missing implicit constructor warnings.
- factory Database._() { throw new UnsupportedError("Not supported"); }
@DomName('IDBDatabase.abortEvent')
@DocsEditable
@@ -450,8 +444,6 @@ class IdbFactory native "IDBFactory" {
'!!(#.getDatabaseNames || #.webkitGetDatabaseNames)', this, this);
}
- // To suppress missing implicit constructor warnings.
- factory IdbFactory._() { throw new UnsupportedError("Not supported"); }
@DomName('IDBFactory.cmp')
@DocsEditable
@@ -599,9 +591,7 @@ class Index native "IDBIndex" {
return ObjectStore._cursorStreamFromResult(request, autoAdvance);
}
- // To suppress missing implicit constructor warnings.
- factory Index._() { throw new UnsupportedError("Not supported"); }
-
+
@DomName('IDBIndex.keyPath')
@DocsEditable
@annotation_Creates_SerializedScriptValue
@@ -688,8 +678,6 @@ class KeyRange native "IDBKeyRange" {
_KeyRangeFactoryProvider.createKeyRange_bound(
lower, upper, lowerOpen, upperOpen);
- // To suppress missing implicit constructor warnings.
- factory KeyRange._() { throw new UnsupportedError("Not supported"); }
@DomName('IDBKeyRange.lower')
@DocsEditable
@@ -870,8 +858,6 @@ class ObjectStore native "IDBObjectStore" {
return $dom_createIndex(name, keyPath, options);
}
- // To suppress missing implicit constructor warnings.
- factory ObjectStore._() { throw new UnsupportedError("Not supported"); }
@DomName('IDBObjectStore.autoIncrement')
@DocsEditable
@@ -1070,8 +1056,6 @@ class ObjectStore native "IDBObjectStore" {
@DomName('IDBOpenDBRequest')
@Unstable
class OpenDBRequest extends Request implements EventTarget native "IDBOpenDBRequest" {
- // To suppress missing implicit constructor warnings.
- factory OpenDBRequest._() { throw new UnsupportedError("Not supported"); }
@DomName('IDBOpenDBRequest.blockedEvent')
@DocsEditable
@@ -1098,8 +1082,6 @@ class OpenDBRequest extends Request implements EventTarget native "IDBOpenDBRequ
@DomName('IDBRequest')
@Unstable
class Request extends EventTarget native "IDBRequest" {
- // To suppress missing implicit constructor warnings.
- factory Request._() { throw new UnsupportedError("Not supported"); }
@DomName('IDBRequest.errorEvent')
@DocsEditable
@@ -1197,8 +1179,6 @@ class Transaction extends EventTarget native "IDBTransaction" {
return completer.future;
}
- // To suppress missing implicit constructor warnings.
- factory Transaction._() { throw new UnsupportedError("Not supported"); }
@DomName('IDBTransaction.abortEvent')
@DocsEditable
@@ -1276,8 +1256,6 @@ class Transaction extends EventTarget native "IDBTransaction" {
@DomName('IDBVersionChangeEvent')
@Unstable
class VersionChangeEvent extends Event native "IDBVersionChangeEvent" {
- // To suppress missing implicit constructor warnings.
- factory VersionChangeEvent._() { throw new UnsupportedError("Not supported"); }
@DomName('IDBVersionChangeEvent.newVersion')
@DocsEditable
@@ -1300,6 +1278,4 @@ class VersionChangeEvent extends Event native "IDBVersionChangeEvent" {
@DomName('IDBAny')
@deprecated // nonstandard
abstract class _IDBAny native "IDBAny" {
- // To suppress missing implicit constructor warnings.
- factory _IDBAny._() { throw new UnsupportedError("Not supported"); }
}
« no previous file with comments | « sdk/lib/html/dartium/nativewrappers.dart ('k') | sdk/lib/indexed_db/dartium/indexed_db_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698