tools/dom/templates/html/dart2js/impl_RTCSessionDescription.darttemplate - Issue 17508002: Revert "Making all DOM types abstract and removing superfluous Dartium constructors."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/templates/html/dart2js/impl_RTCSessionDescription.darttemplate

Issue 17508002: Revert "Making all DOM types abstract and removing superfluous Dartium constructors." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/dom/templates/html/dart2js/impl_RTCIceCandidate.darttemplate ('k') | tools/dom/templates/html/dart2js/impl_SpeechRecognition.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/dom/templates/html/dart2js/impl_RTCSessionDescription.darttemplate

diff --git a/tools/dom/templates/html/dart2js/impl_RTCSessionDescription.darttemplate b/tools/dom/templates/html/dart2js/impl_RTCSessionDescription.darttemplate

index 9592eb5a2be6730d5f960285ee8cc7d7d19aec45..6dd65b4ff4608c29ccff2464e1a4e72555b7c83c 100644

--- a/tools/dom/templates/html/dart2js/impl_RTCSessionDescription.darttemplate

+++ b/tools/dom/templates/html/dart2js/impl_RTCSessionDescription.darttemplate

@@ -4,15 +4,15 @@

part of $LIBRARYNAME;

-$(ANNOTATIONS)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {

+$(ANNOTATIONS)class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {

factory $CLASSNAME(Map dictionary) {

// TODO(efortuna): Remove this check if when you can actually construct with

// the unprefixed RTCIceCandidate in Firefox (currently both are defined,

// but one can't be used as a constructor).

var constructorName = JS('', 'window[#]',

- Device.isFirefox ? '${Device.propertyPrefix}RTCSessionDescription' :

+ Device.isFirefox ? '${Device.propertyPrefix}RTCSessionDescription' :

'RTCSessionDescription');

- return JS('RtcSessionDescription',

+ return JS('RtcSessionDescription',

'new #(#)', constructorName,

convertDartToNative_SerializedScriptValue(dictionary));

}