Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: sdk/lib/web_sql/dartium/web_sql_dartium.dart

Issue 17508002: Revert "Making all DOM types abstract and removing superfluous Dartium constructors." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/web_sql/dart2js/web_sql_dart2js.dart ('k') | tools/dom/scripts/htmldartgenerator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/web_sql/dartium/web_sql_dartium.dart
diff --git a/sdk/lib/web_sql/dartium/web_sql_dartium.dart b/sdk/lib/web_sql/dartium/web_sql_dartium.dart
index 3c9afe503b846ccfca3ca65b6804b3c3816e031e..b057cc8d5a0597946b230cd50bcdd516a666e0d6 100644
--- a/sdk/lib/web_sql/dartium/web_sql_dartium.dart
+++ b/sdk/lib/web_sql/dartium/web_sql_dartium.dart
@@ -82,8 +82,7 @@ typedef void SqlTransactionErrorCallback(SqlError error);
// http://www.w3.org/TR/webdatabase/#asynchronous-database-api
@Experimental // deprecated
class SqlDatabase extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory SqlDatabase._() { throw new UnsupportedError("Not supported"); }
+ SqlDatabase.internal();
/// Checks if this type is supported on the current platform.
static bool get supported => true;
@@ -129,8 +128,7 @@ class SqlDatabase extends NativeFieldWrapperClass1 {
// http://www.w3.org/TR/webdatabase/#sqlerror
@Experimental // deprecated
class SqlError extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory SqlError._() { throw new UnsupportedError("Not supported"); }
+ SqlError.internal();
@DomName('SQLError.CONSTRAINT_ERR')
@DocsEditable
@@ -185,8 +183,7 @@ class SqlError extends NativeFieldWrapperClass1 {
// http://www.w3.org/TR/webdatabase/#sqlexception
@Experimental // deprecated
class SqlException extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory SqlException._() { throw new UnsupportedError("Not supported"); }
+ SqlException.internal();
@DomName('SQLException.CONSTRAINT_ERR')
@DocsEditable
@@ -241,8 +238,7 @@ class SqlException extends NativeFieldWrapperClass1 {
// http://www.w3.org/TR/webdatabase/#sqlresultset
@Experimental // deprecated
class SqlResultSet extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory SqlResultSet._() { throw new UnsupportedError("Not supported"); }
+ SqlResultSet.internal();
@DomName('SQLResultSet.insertId')
@DocsEditable
@@ -269,8 +265,7 @@ class SqlResultSet extends NativeFieldWrapperClass1 {
// http://www.w3.org/TR/webdatabase/#sqlresultsetrowlist
@Experimental // deprecated
class SqlResultSetRowList extends NativeFieldWrapperClass1 with ListMixin<Map>, ImmutableListMixin<Map> implements List<Map> {
- // To suppress missing implicit constructor warnings.
- factory SqlResultSetRowList._() { throw new UnsupportedError("Not supported"); }
+ SqlResultSetRowList.internal();
@DomName('SQLResultSetRowList.length')
@DocsEditable
@@ -341,8 +336,7 @@ class SqlResultSetRowList extends NativeFieldWrapperClass1 with ListMixin<Map>,
// http://www.w3.org/TR/webdatabase/#sqltransaction
@deprecated // deprecated
class SqlTransaction extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory SqlTransaction._() { throw new UnsupportedError("Not supported"); }
+ SqlTransaction.internal();
@DomName('SQLTransaction.executeSql')
@DocsEditable
@@ -364,7 +358,6 @@ class SqlTransaction extends NativeFieldWrapperClass1 {
// http://www.w3.org/TR/webdatabase/#sqltransactionsync
@Experimental // deprecated
abstract class _SQLTransactionSync extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory _SQLTransactionSync._() { throw new UnsupportedError("Not supported"); }
+ _SQLTransactionSync.internal();
}
« no previous file with comments | « sdk/lib/web_sql/dart2js/web_sql_dart2js.dart ('k') | tools/dom/scripts/htmldartgenerator.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698