Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 1750793002: Delete content sandbox tests which exercise handle inheritance (Closed)

Created:
4 years, 9 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 9 months ago
Reviewers:
jam, Will Harris
CC:
chromium-reviews, darin-cc_chromium.org, jam, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete content sandbox tests which exercise handle inheritance Sandboxing content_browsertests seems to break Win10 bots. It's not clear why, but ultimately these tests are probably not worth the trouble: the unsandboxed case is just a glorified base::LaunchProcess test, and the sandboxed case is allready covered by a policy test in sbox_integration_tests. BUG=590490 Committed: https://crrev.com/b7e5cabccbc6297a67af7960ac4b0d5afe36089d Cr-Commit-Position: refs/heads/master@{#378455}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -329 lines) Patch
D content/common/sandbox_win_unittest.cc View 1 chunk +0 lines, -328 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
Ken Rockot(use gerrit already)
4 years, 9 months ago (2016-03-01 01:03:24 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750793002/1
4 years, 9 months ago (2016-03-01 01:04:42 UTC) #4
Will Harris
lgtm
4 years, 9 months ago (2016-03-01 02:02:53 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-01 02:18:30 UTC) #7
jam
lgtm
4 years, 9 months ago (2016-03-01 16:40:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750793002/1
4 years, 9 months ago (2016-03-01 16:42:03 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 16:47:46 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 16:49:09 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7e5cabccbc6297a67af7960ac4b0d5afe36089d
Cr-Commit-Position: refs/heads/master@{#378455}

Powered by Google App Engine
This is Rietveld 408576698