Remove invalid URI in an attempt to fix a windows bug.

Remove invalid URI in an attempt to fix a windows bug.

Committed: https://github.com/dart-lang/sdk/commit/06774c315f321cf5cfabd91d553508f081dfbddc

[Brian Wilkerson, 2016-02-29 22:42:40]

brianwilkerson@google.com changed reviewers:
+ paulberry@google.com

[Brian Wilkerson, 2016-02-29 22:42:41]

I have no idea why "<unnamed source>" wouldn't also be an invalid file path on
Linux machines, but I believe that this will fix the problem.

[Paul Berry, 2016-03-01 17:14:32]

https://codereview.chromium.org/1750773002/diff/1/pkg/analyzer/test/parse_com...
File pkg/analyzer/test/parse_compilation_unit_test.dart (right):

https://codereview.chromium.org/1750773002/diff/1/pkg/analyzer/test/parse_com...
pkg/analyzer/test/parse_compilation_unit_test.dart:34:
error.toString().contains("Error in null: Expected to find ';'");
It seems like a shame to expose the user to the phrase "Error in null".

How about if we change AnalyzerError.toString() so that if
`error.source.shortName` is null, it defaults to '<unknown source>'?  That way
we would still avoid the Windows bug but user-visible behavior wouldn't be
degraded.

[Brian Wilkerson, 2016-03-02 16:31:00]

https://codereview.chromium.org/1750773002/diff/1/pkg/analyzer/test/parse_com...
File pkg/analyzer/test/parse_compilation_unit_test.dart (right):

https://codereview.chromium.org/1750773002/diff/1/pkg/analyzer/test/parse_com...
pkg/analyzer/test/parse_compilation_unit_test.dart:34:
error.toString().contains("Error in null: Expected to find ';'");
You're right, that is better. Done.

[Brian Wilkerson, 2016-03-02 16:31:25]

Description was changed from

==========
Remove invalid URI in an attempt to fix a windows bug.
==========

to

==========
Remove invalid URI in an attempt to fix a windows bug.

Committed:
https://github.com/dart-lang/sdk/commit/06774c315f321cf5cfabd91d553508f081dfbddc
==========

[Brian Wilkerson, 2016-03-02 16:31:26]

Committed patchset #1 (id:1) manually as
06774c315f321cf5cfabd91d553508f081dfbddc (presubmit successful).

[Paul Berry, 2016-03-02 17:22:50]

lgtm