Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1750733002: Revert of Fix git recipe module to use git.bad as package resouce. (Closed)

Created:
4 years, 9 months ago by tandrii(chromium)
Modified:
4 years, 9 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Fix git recipe module to use git.bad as package resouce. (patchset #1 id:1 of https://codereview.chromium.org/1742403002/ ) Reason for revert: broke win builder bug 590806 Original issue's description: > Fix git recipe module to use git.bad as package resouce. > > R=phajdan.jr@chromium.org > BUG=579160 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299005 TBR=phajdan.jr@chromium.org,tandrii@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=579160 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299011

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -19 lines) Patch
M recipe_modules/git/api.py View 2 chunks +3 lines, -2 lines 0 comments Download
M recipe_modules/git/example.expected/platform_win.json View 15 chunks +16 lines, -16 lines 0 comments Download
M recipe_modules/tryserver/example.expected/with_wrong_patch.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
tandrii(chromium)
Created Revert of Fix git recipe module to use git.bad as package resouce.
4 years, 9 months ago (2016-02-29 19:40:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750733002/1
4 years, 9 months ago (2016-02-29 19:41:02 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 19:41:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299011

Powered by Google App Engine
This is Rietveld 408576698