Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1750683002: Move folderMap from AnalysisContext to ContextManager (Closed)

Created:
4 years, 9 months ago by Brian Wilkerson
Modified:
4 years, 9 months ago
Reviewers:
Paul Berry, scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -40 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 12 chunks +23 lines, -23 lines 2 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 4 chunks +22 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_diagnostic.dart View 2 chunks +5 lines, -5 lines 2 comments Download
M pkg/analysis_server/lib/src/domain_execution.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/status/get_handler.dart View 3 chunks +5 lines, -4 lines 2 comments Download
M pkg/analysis_server/test/analysis/reanalyze_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/domain_execution_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Brian Wilkerson
4 years, 9 months ago (2016-02-29 18:55:42 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1750683002/diff/1/pkg/analysis_server/lib/src/domain_diagnostic.dart File pkg/analysis_server/lib/src/domain_diagnostic.dart (right): https://codereview.chromium.org/1750683002/diff/1/pkg/analysis_server/lib/src/domain_diagnostic.dart#newcode45 pkg/analysis_server/lib/src/domain_diagnostic.dart:45: ; Remove this line. https://codereview.chromium.org/1750683002/diff/1/pkg/analysis_server/lib/src/status/get_handler.dart File pkg/analysis_server/lib/src/status/get_handler.dart (right): ...
4 years, 9 months ago (2016-02-29 19:03:38 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/1750683002/diff/1/pkg/analysis_server/lib/src/domain_diagnostic.dart File pkg/analysis_server/lib/src/domain_diagnostic.dart (right): https://codereview.chromium.org/1750683002/diff/1/pkg/analysis_server/lib/src/domain_diagnostic.dart#newcode45 pkg/analysis_server/lib/src/domain_diagnostic.dart:45: ; Done https://codereview.chromium.org/1750683002/diff/1/pkg/analysis_server/lib/src/status/get_handler.dart File pkg/analysis_server/lib/src/status/get_handler.dart (right): https://codereview.chromium.org/1750683002/diff/1/pkg/analysis_server/lib/src/status/get_handler.dart#newcode712 pkg/analysis_server/lib/src/status/get_handler.dart:712: ; ...
4 years, 9 months ago (2016-02-29 20:45:11 UTC) #4
Paul Berry
lgtm https://codereview.chromium.org/1750683002/diff/1/pkg/analysis_server/lib/src/analysis_server.dart File pkg/analysis_server/lib/src/analysis_server.dart (right): https://codereview.chromium.org/1750683002/diff/1/pkg/analysis_server/lib/src/analysis_server.dart#newcode1328 pkg/analysis_server/lib/src/analysis_server.dart:1328: ; Stray `;`
4 years, 9 months ago (2016-02-29 21:46:31 UTC) #6
Brian Wilkerson
https://codereview.chromium.org/1750683002/diff/1/pkg/analysis_server/lib/src/analysis_server.dart File pkg/analysis_server/lib/src/analysis_server.dart (right): https://codereview.chromium.org/1750683002/diff/1/pkg/analysis_server/lib/src/analysis_server.dart#newcode1328 pkg/analysis_server/lib/src/analysis_server.dart:1328: ; Done
4 years, 9 months ago (2016-02-29 22:04:13 UTC) #7
Brian Wilkerson
4 years, 9 months ago (2016-02-29 22:04:51 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
c4d7f416505d70fb00638c3468700b69fa3c6406 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698