components/exo: Extend pointer to use v5 protocol

components/exo: Extend pointer to use v5 protocol

The v5 protocol allows us to add support for smooth scrolling with
flings.

BUG=chromium:590754
TEST=updated unit test included

Committed: https://crrev.com/73513876700397ec4da77edcb929537a235a2a05
Cr-Commit-Position: refs/heads/master@{#378837}

[denniskempin, 2016-03-02 00:15:12]

denniskempin@google.com changed reviewers:
+ reveman@chromium.org

[denniskempin, 2016-03-02 00:15:13]

Unittests are working. CL is good to go! PTAL!

[reveman, 2016-03-02 04:16:53]

lgtm with nits

https://codereview.chromium.org/1750633002/diff/40001/components/exo/pointer.cc
File components/exo/pointer.cc (right):

https://codereview.chromium.org/1750633002/diff/40001/components/exo/pointer....
components/exo/pointer.cc:134: if (focus_) {
nit: not need for "{" "}"

https://codereview.chromium.org/1750633002/diff/40001/components/exo/pointer....
components/exo/pointer.cc:140: // Wayland doesn't know the concept of a fling
cancel. But we can send a
nit: please add a OnPointerScrollStart (feel free to pick a better name if you
can think one) function to the delegate interface and keep this wayland specific
comment and 0 distance scroll in the wayland code.

https://codereview.chromium.org/1750633002/diff/40001/components/exo/pointer....
components/exo/pointer.cc:156: if (focus_) {
nit: not need for "{" "}"

https://codereview.chromium.org/1750633002/diff/40001/components/exo/pointer_...
File components/exo/pointer_unittest.cc (right):

https://codereview.chromium.org/1750633002/diff/40001/components/exo/pointer_...
components/exo/pointer_unittest.cc:54: EXPECT_CALL(delegate,
OnPointerFrame()).Times(testing::AnyNumber());
nit: Can we use an exact number of expected calls here and below instead of
testing::AnyNumber()?

https://codereview.chromium.org/1750633002/diff/40001/components/exo/pointer_...
components/exo/pointer_unittest.cc:206: TEST_F(PointerTest,
OnPointerWheelScroll) {
nit: OnPointerScrollDiscrete and maybe move the test below the OnPointerScroll
test below

https://codereview.chromium.org/1750633002/diff/40001/components/exo/pointer_...
components/exo/pointer_unittest.cc:234: TEST_F(PointerTest,
OnPointerSmoothScroll) {
nit: I think we can keep the existing "OnPointerScroll" name here

https://codereview.chromium.org/1750633002/diff/40001/components/exo/pointer_...
components/exo/pointer_unittest.cc:255: {  // Expect fling stop followed by
scroll and scroll stop
nit: move the comment to the line below and add "." at the end of sentence.

[denniskempin, 2016-03-02 20:47:58]

fixed nits

https://codereview.chromium.org/1750633002/diff/40001/components/exo/pointer.cc
File components/exo/pointer.cc (right):

https://codereview.chromium.org/1750633002/diff/40001/components/exo/pointer....
components/exo/pointer.cc:134: if (focus_) {
On 2016/03/02 04:16:53, reveman wrote:
> nit: not need for "{" "}"

Done.

https://codereview.chromium.org/1750633002/diff/40001/components/exo/pointer....
components/exo/pointer.cc:140: // Wayland doesn't know the concept of a fling
cancel. But we can send a
On 2016/03/02 04:16:52, reveman wrote:
> nit: please add a OnPointerScrollStart (feel free to pick a better name if you
> can think one) function to the delegate interface and keep this wayland
specific
> comment and 0 distance scroll in the wayland code. 

Done.

https://codereview.chromium.org/1750633002/diff/40001/components/exo/pointer....
components/exo/pointer.cc:156: if (focus_) {
On 2016/03/02 04:16:52, reveman wrote:
> nit: not need for "{" "}"

Done.

https://codereview.chromium.org/1750633002/diff/40001/components/exo/pointer_...
File components/exo/pointer_unittest.cc (right):

https://codereview.chromium.org/1750633002/diff/40001/components/exo/pointer_...
components/exo/pointer_unittest.cc:54: EXPECT_CALL(delegate,
OnPointerFrame()).Times(testing::AnyNumber());
On 2016/03/02 04:16:53, reveman wrote:
> nit: Can we use an exact number of expected calls here and below instead of
> testing::AnyNumber()?

Done.

https://codereview.chromium.org/1750633002/diff/40001/components/exo/pointer_...
components/exo/pointer_unittest.cc:206: TEST_F(PointerTest,
OnPointerWheelScroll) {
On 2016/03/02 04:16:53, reveman wrote:
> nit: OnPointerScrollDiscrete and maybe move the test below the OnPointerScroll
> test below

Done.

https://codereview.chromium.org/1750633002/diff/40001/components/exo/pointer_...
components/exo/pointer_unittest.cc:234: TEST_F(PointerTest,
OnPointerSmoothScroll) {
On 2016/03/02 04:16:53, reveman wrote:
> nit: I think we can keep the existing "OnPointerScroll" name here 

Done.

https://codereview.chromium.org/1750633002/diff/40001/components/exo/pointer_...
components/exo/pointer_unittest.cc:255: {  // Expect fling stop followed by
scroll and scroll stop
On 2016/03/02 04:16:53, reveman wrote:
> nit: move the comment to the line below and add "." at the end of sentence.

Done.

[denniskempin, 2016-03-02 20:48:07]

The CQ bit was checked by denniskempin@google.com

[denniskempin, 2016-03-02 20:48:08]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/1750633002/#ps60001
(title: "fixed nits")

[commit-bot: I haz the power, 2016-03-02 20:48:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1750633002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1750633002/60001

[commit-bot: I haz the power, 2016-03-02 21:31:15]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-02 21:32:11]

Description was changed from

==========
components/exo: Extend pointer to use v5 protocol

The v5 protocol allows us to add support for smooth scrolling with
flings.

BUG=chromium:590754
TEST=updated unit test included
==========

to

==========
components/exo: Extend pointer to use v5 protocol

The v5 protocol allows us to add support for smooth scrolling with
flings.

BUG=chromium:590754
TEST=updated unit test included

Committed: https://crrev.com/73513876700397ec4da77edcb929537a235a2a05
Cr-Commit-Position: refs/heads/master@{#378837}
==========

[commit-bot: I haz the power, 2016-03-02 21:32:12]

Patchset 4 (id:??) landed as
https://crrev.com/73513876700397ec4da77edcb929537a235a2a05
Cr-Commit-Position: refs/heads/master@{#378837}