Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1298)

Unified Diff: pkg/compiler/lib/src/cps_ir/eagerly_load_statics.dart

Issue 1750583002: Revert "dart2js cps: Refactor tracking of side effects." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart ('k') | pkg/compiler/lib/src/cps_ir/effects.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/cps_ir/eagerly_load_statics.dart
diff --git a/pkg/compiler/lib/src/cps_ir/eagerly_load_statics.dart b/pkg/compiler/lib/src/cps_ir/eagerly_load_statics.dart
index e03f9cad33bc96a02b3daaa241c94945cdb25fd9..6f733e31f02e5df72ad70f907d39342804537361 100644
--- a/pkg/compiler/lib/src/cps_ir/eagerly_load_statics.dart
+++ b/pkg/compiler/lib/src/cps_ir/eagerly_load_statics.dart
@@ -7,7 +7,6 @@ library dart2js.cps_ir.eagerly_load_statics;
import 'cps_ir_nodes.dart';
import 'optimizers.dart' show Pass;
import '../elements/elements.dart';
-import 'cps_fragment.dart';
/// Replaces [GetLazyStatic] with [GetStatic] when the static field is known
/// to have been initialized.
@@ -31,12 +30,6 @@ class EagerlyLoadStatics extends TrampolineRecursiveVisitor implements Pass {
visit(node.body);
}
- Expression traverseLetPrim(LetPrim node) {
- Expression next = node.body;
- visit(node.primitive);
- return next;
- }
-
Expression traverseLetCont(LetCont node) {
for (Continuation cont in node.continuations) {
initializersAt[cont] = cloneFieldMap(initializerFor);
@@ -58,13 +51,10 @@ class EagerlyLoadStatics extends TrampolineRecursiveVisitor implements Pass {
void visitGetLazyStatic(GetLazyStatic node) {
Primitive initializer = initializerFor[node.element];
- if (initializer is GetLazyStatic && initializer.isFinal) {
- // No reason to create a GetStatic when the field is final.
- node.replaceWithFragment(new CpsFragment(), initializer);
- } else if (initializer != null) {
- GetStatic newNode = new GetStatic.witnessed(node.element,
- initializer, sourceInformation: node.sourceInformation)
- ..type = node.type;
+ if (initializer != null) {
+ GetStatic newNode = new GetStatic.witnessed(node.element, initializer,
+ node.sourceInformation);
+ newNode.type = node.type;
node.replaceWith(newNode);
} else {
initializerFor[node.element] = node;
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart ('k') | pkg/compiler/lib/src/cps_ir/effects.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698