Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

Issue 1750583002: Revert "dart2js cps: Refactor tracking of side effects." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart ('k') | pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
index cfea55ab65778d5937a52792dcfeb99ef8969315..629bfacd47f6ed16b1bed54cab24df715632112e 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
@@ -878,13 +878,9 @@ class IrBuilderVisitor extends ast.Visitor<ir.Primitive>
typeMaskSystem.associateConstantValueWithElement(constant, field);
return irBuilder.buildConstant(constant, sourceInformation: src);
} else if (backend.constants.lazyStatics.contains(field)) {
- return irBuilder.addPrimitive(new ir.GetLazyStatic(field,
- sourceInformation: src,
- isFinal: compiler.world.fieldNeverChanges(field)));
+ return irBuilder.addPrimitive(new ir.GetLazyStatic(field, src));
} else {
- return irBuilder.addPrimitive(new ir.GetStatic(field,
- sourceInformation: src,
- isFinal: compiler.world.fieldNeverChanges(field)));
+ return irBuilder.addPrimitive(new ir.GetStatic(field, src));
}
}
@@ -1940,7 +1936,7 @@ class IrBuilderVisitor extends ast.Visitor<ir.Primitive>
ast.Send node,
MethodElement function,
_) {
- return irBuilder.addPrimitive(new ir.GetStatic(function, isFinal: true));
+ return irBuilder.addPrimitive(new ir.GetStatic(function));
}
@override
@@ -2906,8 +2902,7 @@ class IrBuilderVisitor extends ast.Visitor<ir.Primitive>
case CompoundGetter.GETTER:
return buildStaticGetterGet(getter, node);
case CompoundGetter.METHOD:
- return irBuilder.addPrimitive(new ir.GetStatic(getter,
- isFinal: true));
+ return irBuilder.addPrimitive(new ir.GetStatic(getter));
case CompoundGetter.UNRESOLVED:
return irBuilder.buildStaticNoSuchMethod(
new Selector.getter(new Name(getter.name, getter.library)),
@@ -2947,8 +2942,7 @@ class IrBuilderVisitor extends ast.Visitor<ir.Primitive>
case CompoundGetter.GETTER:
return buildStaticGetterGet(getter, node);
case CompoundGetter.METHOD:
- return irBuilder.addPrimitive(new ir.GetStatic(getter,
- isFinal: true));
+ return irBuilder.addPrimitive(new ir.GetStatic(getter));
case CompoundGetter.UNRESOLVED:
return irBuilder.buildStaticNoSuchMethod(
new Selector.getter(new Name(getter.name, getter.library)),
@@ -4020,10 +4014,6 @@ class GlobalProgramInformation {
return _compiler.world.locateSingleField(selector, type);
}
- bool fieldNeverChanges(FieldElement field) {
- return _compiler.world.fieldNeverChanges(field);
- }
-
Element get closureConverter {
return _backend.helpers.closureConverter;
}
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart ('k') | pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698