Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1750573002: [interpreter] Fix test-serialize/SerializeToplevelIsolates. (Closed)

Created:
4 years, 9 months ago by Yang
Modified:
4 years, 9 months ago
Reviewers:
rmcilroy, mythria
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Fix test-serialize/SerializeToplevelIsolates. R=rmcilroy@chromium.org BUG=v8:4680 LOG=N Committed: https://crrev.com/7b693cc4abe6c80665e2233795a2343e4a4a262e Cr-Commit-Position: refs/heads/master@{#34389}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M src/snapshot/serialize.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Yang
4 years, 9 months ago (2016-02-29 14:25:36 UTC) #1
Yang
4 years, 9 months ago (2016-03-01 12:39:02 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750573002/1
4 years, 9 months ago (2016-03-01 12:44:07 UTC) #6
mythria
Thanks, lgtm
4 years, 9 months ago (2016-03-01 13:06:32 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-01 13:08:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750573002/1
4 years, 9 months ago (2016-03-01 13:45:21 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 13:47:05 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 13:47:17 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b693cc4abe6c80665e2233795a2343e4a4a262e
Cr-Commit-Position: refs/heads/master@{#34389}

Powered by Google App Engine
This is Rietveld 408576698