Issue 175055: [Mac] Fix Omnibox keyword-search color.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 175055: [Mac] Fix Omnibox keyword-search color. (Closed)

Created:
11 years, 3 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
John Grabowski

CC:
chromium-reviews_googlegroups.com, Glen Murphy

Visibility:
Public.

Description

[Mac] Fix Omnibox keyword-search color. Originally was using theme colors, which seem to have changed. http://crbug.com/20556 TEST=Type www.google.com and hit tab, should see "Search Google:" in a bubble. The bubble should be blue with a darker background.

Patch Set 1 #

Patch Set 2 : Comment jankiness #

Patch Set 3 : Making sure nothing has changed. #

Patch Set 4 : Indeed, something HAD changed. Expect a poor merge, change it back. #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
	M	chrome/browser/cocoa/autocomplete_text_field_cell.mm	View	1 2 3	1 chunk	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

John, I had sent this to Glen because I had discussed how to resolve this ...

11 years, 3 months ago (2009-09-04 17:46:46 UTC) #3

Glen Murphy

11 years, 3 months ago (2009-09-04 19:16:12 UTC) #5

Sorry for letting this one fall through.

On Friday, September 4, 2009,  <jrg@chromium.org> wrote:
> Yes; seems reasonable from my seat.
>
> LGTM
>
>
>
> http://codereview.chromium.org/175055
>

-- 
Reminder: I will be on vacation from September 17 - 30, and will
probably be out of internet range (Egypt) until the 27th (Paris).

Expand Messages | Collapse Messages