Fix accidental bug in yield* desugaring.

Fix accidental bug in yield* desugaring.

The for-of-finalization CL incorrectly removed the input argument from
BuildIteratorClose.  I'm reverting this, adding a regression test, and fixing an
existing test that was wrong.

BUG=
R=rossberg

Committed: https://crrev.com/ef8fa8521c1ab941a9fab68f046e9b0d77f79b77
Cr-Commit-Position: refs/heads/master@{#34384}

[neis, 2016-02-29 12:04:51]

Description was changed from

==========
Fix accidental bug in yield* desugaring.

The for-of-finalization CL incorrectly removed the input argument from
BuildIteratorClose.  I'm reverting this, adding a regression test, and fixing an
existing test that was wrong.

BUG=
R=rossberg
==========

to

==========
Fix accidental bug in yield* desugaring.

The for-of-finalization CL incorrectly removed the input argument from
BuildIteratorClose.  I'm reverting this, adding a regression test, and fixing an
existing test that was wrong.

BUG=
R=rossberg
==========

[neis, 2016-02-29 12:04:51]

neis@chromium.org changed reviewers:
+ littledan@chromium.org

[neis, 2016-02-29 12:05:06]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-29 12:05:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1750543002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1750543002/1

[commit-bot: I haz the power, 2016-02-29 12:30:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-29 12:30:54]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2016-02-29 16:41:45]

littledan@chromium.org changed reviewers:
+ rossberg@chromium.orgc
- rossberg@chromium.org

[Dan Ehrenberg, 2016-02-29 16:41:45]

Where is this argument mentioned in the spec? I couldn't find it, which is why I
brought up removing it during Andreas's code review.

[rossberg, 2016-02-29 16:44:18]

rossberg@chromium.org changed reviewers:
+ rossberg@chromium.org

[rossberg, 2016-02-29 16:44:18]

I wouldn't mind some comment around the declaration of BuildOperatorClose that
explains the purpose of this argument, esp in comparison to the spec.

[neis, 2016-03-01 09:02:00]

I added a clarifying comment (it will answer your question, Dan).

[Dan Ehrenberg, 2016-03-01 09:11:35]

lgtm

OK, now I get it. Sorry for the earlier spec misread on my part.

[neis, 2016-03-01 09:13:02]

The CQ bit was checked by neis@chromium.org

[commit-bot: I haz the power, 2016-03-01 09:13:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1750543002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1750543002/20001

[commit-bot: I haz the power, 2016-03-01 09:38:59]

Description was changed from

==========
Fix accidental bug in yield* desugaring.

The for-of-finalization CL incorrectly removed the input argument from
BuildIteratorClose.  I'm reverting this, adding a regression test, and fixing an
existing test that was wrong.

BUG=
R=rossberg
==========

to

==========
Fix accidental bug in yield* desugaring.

The for-of-finalization CL incorrectly removed the input argument from
BuildIteratorClose.  I'm reverting this, adding a regression test, and fixing an
existing test that was wrong.

BUG=
R=rossberg
==========

[commit-bot: I haz the power, 2016-03-01 09:39:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-01 09:39:26]

Description was changed from

==========
Fix accidental bug in yield* desugaring.

The for-of-finalization CL incorrectly removed the input argument from
BuildIteratorClose.  I'm reverting this, adding a regression test, and fixing an
existing test that was wrong.

BUG=
R=rossberg
==========

to

==========
Fix accidental bug in yield* desugaring.

The for-of-finalization CL incorrectly removed the input argument from
BuildIteratorClose.  I'm reverting this, adding a regression test, and fixing an
existing test that was wrong.

BUG=
R=rossberg

Committed: https://crrev.com/ef8fa8521c1ab941a9fab68f046e9b0d77f79b77
Cr-Commit-Position: refs/heads/master@{#34384}
==========

[commit-bot: I haz the power, 2016-03-01 09:39:27]

Patchset 2 (id:??) landed as
https://crrev.com/ef8fa8521c1ab941a9fab68f046e9b0d77f79b77
Cr-Commit-Position: refs/heads/master@{#34384}