Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1750533003: Move drawDRRect back to GrDrawContext (Closed)

Created:
4 years, 9 months ago by robertphillips
Modified:
4 years, 9 months ago
CC:
reviews_skia.org, cdalton.nvidia
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move drawDRRect back to GrDrawContext This still leaves GrDrawContext fiddling around with specialized fragment processors but it does allow for different handling of the DRRects (e.g., for instanced drawing). GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1750533003 Committed: https://skia.googlesource.com/skia/+/000958973f4b514cddbfdcc01ec167437b66de2c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -61 lines) Patch
M include/gpu/GrDrawContext.h View 2 chunks +22 lines, -0 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 2 chunks +89 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 3 chunks +5 lines, -61 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
robertphillips
4 years, 9 months ago (2016-02-29 21:11:55 UTC) #4
joshualitt
On 2016/02/29 21:11:55, robertphillips wrote: lgtm
4 years, 9 months ago (2016-02-29 21:12:51 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750533003/1
4 years, 9 months ago (2016-02-29 21:27:55 UTC) #8
bsalomon
lgtm
4 years, 9 months ago (2016-02-29 21:39:00 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-02-29 21:47:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750533003/1
4 years, 9 months ago (2016-02-29 21:49:44 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 21:50:43 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/000958973f4b514cddbfdcc01ec167437b66de2c

Powered by Google App Engine
This is Rietveld 408576698