Issue 175053009: Merge 252733 "Move control of updating toolchain into src/"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 175053009: Merge 252733 "Move control of updating toolchain into src/" (Closed)

Created:
6 years, 10 months ago by scottmg

Modified:
6 years, 10 months ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/branches/1849/src/

Visibility:
Public.

Merge 252733 "Move control of updating toolchain into src/" > Move control of updating toolchain into src/ > > Moved out of depot_tools here: https://codereview.chromium.org/168603004/ > > The control is in src/ now, but logic for de-duplication is still in depot_tools. > > This changes the default, so that VS2013 will be the default toolchain. > > R=iannucci@chromium.org > BUG=323300, 309197 > > Review URL: https://codereview.chromium.org/175573004 TBR=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252734

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -29 lines)			Patch
	M	build/gyp_chromium	View		4 chunks	+55 lines, -30 lines	0 comments	Download
	A +	build/toolchain_vs2013.hash	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Total messages: 2 (0 generated)

scottmg

6 years, 10 months ago (2014-02-22 02:49:08 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r252734 (tree was closed).