Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1750523002: Update GN docs about Visual Studio generators (Closed)

Created:
4 years, 9 months ago by Tomasz Moniuszko
Modified:
4 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update GN docs about Visual Studio generators BUG= Committed: https://crrev.com/eca97f87e275a7c9c5b7f13a65ff8635f0821d46 Cr-Commit-Position: refs/heads/master@{#378419}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix doc according to review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -17 lines) Patch
M tools/gn/docs/faq.md View 1 1 chunk +5 lines, -13 lines 0 comments Download
M tools/gn/docs/reference.md View 2 chunks +39 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Tomasz Moniuszko
4 years, 9 months ago (2016-02-29 10:59:16 UTC) #2
brettw
thanks, lgtm https://codereview.chromium.org/1750523002/diff/1/tools/gn/docs/faq.md File tools/gn/docs/faq.md (right): https://codereview.chromium.org/1750523002/diff/1/tools/gn/docs/faq.md#newcode38 tools/gn/docs/faq.md:38: XCode is not supported now. Can you ...
4 years, 9 months ago (2016-02-29 18:01:05 UTC) #3
Tomasz Moniuszko
https://codereview.chromium.org/1750523002/diff/1/tools/gn/docs/faq.md File tools/gn/docs/faq.md (right): https://codereview.chromium.org/1750523002/diff/1/tools/gn/docs/faq.md#newcode38 tools/gn/docs/faq.md:38: XCode is not supported now. On 2016/02/29 18:01:05, brettw ...
4 years, 9 months ago (2016-03-01 08:57:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750523002/20001
4 years, 9 months ago (2016-03-01 08:57:37 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-01 09:28:25 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 09:30:06 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eca97f87e275a7c9c5b7f13a65ff8635f0821d46
Cr-Commit-Position: refs/heads/master@{#378419}

Powered by Google App Engine
This is Rietveld 408576698