Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1750503002: Move Deprecation helpers into an anonymous namespace (Closed)

Created:
4 years, 9 months ago by philipj_slow
Modified:
4 years, 9 months ago
Reviewers:
davve
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Deprecation helpers into an anonymous namespace willBeRemoved is used in the first Deprecation::deprecationMessage so unfortunately these can't be kept right next to second Deprecation::deprecationMessage where they are used most. Committed: https://crrev.com/7965936197b25e034cd0f195d3d55679b136942e Cr-Commit-Position: refs/heads/master@{#378206}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -39 lines) Patch
M third_party/WebKit/Source/core/frame/Deprecation.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 2 chunks +41 lines, -37 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750503002/1
4 years, 9 months ago (2016-02-29 09:06:30 UTC) #2
philipj_slow
PTAL
4 years, 9 months ago (2016-02-29 10:18:40 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-02-29 10:34:09 UTC) #6
davve
lgtm The description reads a bit funny since the same member function name is mentioned ...
4 years, 9 months ago (2016-02-29 13:21:32 UTC) #7
philipj_slow
On 2016/02/29 13:21:32, David Vest wrote: > lgtm > > The description reads a bit ...
4 years, 9 months ago (2016-02-29 13:28:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750503002/1
4 years, 9 months ago (2016-02-29 13:36:43 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-29 13:41:56 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 13:43:22 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7965936197b25e034cd0f195d3d55679b136942e
Cr-Commit-Position: refs/heads/master@{#378206}

Powered by Google App Engine
This is Rietveld 408576698