Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1750463002: Fix use-after-free in Android Origin Info Bubble (Closed)

Created:
4 years, 9 months ago by tsergeant
Modified:
4 years, 9 months ago
Reviewers:
Ted C
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix use-after-free in Android Origin Info Bubble In crrev.com/376883, a native call was added to the Android OIB which was possible to be triggered while the dialog was closing, after the native object had been destructed. This caused a use-after-free error. This CL ensures that the RecordWebsiteSettingsAction native call will only fire if the native object is still available. BUG=590616 Committed: https://crrev.com/18dce56331b3861a448f0633c7acf3c61ef6e569 Cr-Commit-Position: refs/heads/master@{#378333}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750463002/1
4 years, 9 months ago (2016-02-29 07:59:18 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-02-29 08:41:54 UTC) #4
tsergeant
tedchoc@, please take a look.
4 years, 9 months ago (2016-02-29 22:35:53 UTC) #6
Ted C
lgtm
4 years, 9 months ago (2016-02-29 23:02:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750463002/1
4 years, 9 months ago (2016-02-29 23:48:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 00:07:27 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 00:09:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18dce56331b3861a448f0633c7acf3c61ef6e569
Cr-Commit-Position: refs/heads/master@{#378333}

Powered by Google App Engine
This is Rietveld 408576698