Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: third_party/WebKit/Source/core/streams/ReadableStreamReader.h

Issue 1750453002: Reduce ActiveDOMObjects from core/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/streams/ReadableStreamReader.h
diff --git a/third_party/WebKit/Source/core/streams/ReadableStreamReader.h b/third_party/WebKit/Source/core/streams/ReadableStreamReader.h
index 8bd5f2c490211dfb440605c3945c569457532e46..d743af1391064600ae29bb211be28bd52bc69fba 100644
--- a/third_party/WebKit/Source/core/streams/ReadableStreamReader.h
+++ b/third_party/WebKit/Source/core/streams/ReadableStreamReader.h
@@ -11,7 +11,7 @@
#include "bindings/core/v8/ScriptWrappable.h"
#include "bindings/core/v8/ToV8.h"
#include "core/CoreExport.h"
-#include "core/dom/ActiveDOMObject.h"
+#include "core/dom/ContextLifecycleObserver.h"
#include "core/streams/ReadableStream.h"
#include "platform/heap/Handle.h"
@@ -24,7 +24,7 @@ class ScriptState;
// ReadableStreamReader corresponds to the same-name class in the Streams spec
// https://streams.spec.whatwg.org/.
-class CORE_EXPORT ReadableStreamReader final : public GarbageCollectedFinalized<ReadableStreamReader>, public ScriptWrappable, public ActiveDOMObject {
+class CORE_EXPORT ReadableStreamReader final : public GarbageCollectedFinalized<ReadableStreamReader>, public ScriptWrappable, public ContextLifecycleObserver {
DEFINE_WRAPPERTYPEINFO();
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(ReadableStreamReader);
public:
@@ -42,7 +42,7 @@ public:
void error();
bool hasPendingActivity() const override;
- void stop() override;
+ void contextDestroyed() override;
DECLARE_TRACE();

Powered by Google App Engine
This is Rietveld 408576698