Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: third_party/WebKit/Source/core/page/EventSource.h

Issue 1750453002: Reduce ActiveDOMObjects from core/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/EventSource.h
diff --git a/third_party/WebKit/Source/core/page/EventSource.h b/third_party/WebKit/Source/core/page/EventSource.h
index 5e12ebab4231fe0484a85edda9c8b3788b552efd..73ef19c3f45c26214151cddc0f8c394df6ffe127 100644
--- a/third_party/WebKit/Source/core/page/EventSource.h
+++ b/third_party/WebKit/Source/core/page/EventSource.h
@@ -32,7 +32,7 @@
#ifndef EventSource_h
#define EventSource_h
-#include "core/dom/ActiveDOMObject.h"
+#include "core/dom/ContextLifecycleObserver.h"
#include "core/events/EventTarget.h"
#include "core/loader/ThreadableLoader.h"
#include "core/loader/ThreadableLoaderClient.h"
@@ -49,7 +49,7 @@ class EventSourceInit;
class ExceptionState;
class ResourceResponse;
-class CORE_EXPORT EventSource final : public RefCountedGarbageCollectedEventTargetWithInlineData<EventSource>, private ThreadableLoaderClient, public ActiveDOMObject, public EventSourceParser::Client {
+class CORE_EXPORT EventSource final : public RefCountedGarbageCollectedEventTargetWithInlineData<EventSource>, private ThreadableLoaderClient, public ContextLifecycleObserver, public EventSourceParser::Client {
DEFINE_WRAPPERTYPEINFO();
REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(EventSource);
USING_GARBAGE_COLLECTED_MIXIN(EventSource);
@@ -79,13 +79,11 @@ public:
const AtomicString& interfaceName() const override;
ExecutionContext* executionContext() const override;
- // ActiveDOMObject
- //
- // Note: suspend() is noop since ScopedPageLoadDeferrer calls
- // Page::setDefersLoading() and it defers delivery of events from the
- // loader, and therefore the methods of this class for receiving
- // asynchronous events from the loader won't be invoked.
- void stop() override;
+ // Note: We don't need to override suspend() because it is noop since
+ // ScopedPageLoadDeferrer calls Page::setDefersLoading() and it defers
+ // delivery of events from the loader, and therefore the methods of this
+ // class for receiving asynchronous events from the loader won't be invoked.
+ void contextDestroyed() override;
bool hasPendingActivity() const override;

Powered by Google App Engine
This is Rietveld 408576698