Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Issue 1750433002: X87: [crankshaft] [ia32] Remove dynamic frame alignment optimization. (Closed)

Created:
4 years, 9 months ago by zhengxing.li
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [crankshaft] [ia32] Remove dynamic frame alignment optimization. port fcb83f2015afe63449f7ab070558e0c7f2accb47(r34273) original commit message: This optimization does not give us much (see perf try bot results associated with this CL) but complicates things a lot. The main motivation is to avoid additional complexity in tail call optim There are some pieces left in the deoptimizer, but I'll address this in a separate CL. BUG= Committed: https://crrev.com/e99ad69147576ee654f0206066c64ca9ab1e9255 Cr-Commit-Position: refs/heads/master@{#34353}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -194 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.h View 3 chunks +1 line, -5 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 7 chunks +16 lines, -149 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M src/x87/deoptimizer-x87.cc View 2 chunks +2 lines, -22 lines 0 comments Download
M src/x87/frames-x87.h View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 9 months ago (2016-02-29 02:51:32 UTC) #2
Weiliang
lgtm
4 years, 9 months ago (2016-02-29 03:03:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750433002/1
4 years, 9 months ago (2016-02-29 03:09:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-29 03:35:27 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 03:36:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e99ad69147576ee654f0206066c64ca9ab1e9255
Cr-Commit-Position: refs/heads/master@{#34353}

Powered by Google App Engine
This is Rietveld 408576698