Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: sdk/lib/_internal/lib/js_mirrors.dart

Issue 175043004: Version 1.2.0-dev.5.14 (Closed) Base URL: http://dart.googlecode.com/svn/trunk/dart/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart ('k') | tools/VERSION » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/lib/js_mirrors.dart
===================================================================
--- sdk/lib/_internal/lib/js_mirrors.dart (revision 32895)
+++ sdk/lib/_internal/lib/js_mirrors.dart (working copy)
@@ -569,7 +569,8 @@
// This is a native class, or an intercepted class.
// TODO(ahe): Preserve descriptor for such classes.
} else {
- fields = JS('', '#[""]', descriptor);
+ fields = JS('', '#[#]', descriptor,
+ JS_GET_NAME('CLASS_DESCRIPTOR_PROPERTY'));
if (fields is List) {
fieldsMetadata = fields.getRange(1, fields.length).toList();
fields = fields[0];
@@ -1592,7 +1593,10 @@
var staticDescriptor = JS('', 'init.statics[#]', _mangledName);
if (staticDescriptor != null) {
parseCompactFieldSpecification(
- fieldOwner, JS('', '#[""]', staticDescriptor), true, result);
+ fieldOwner,
+ JS('', '#[#]',
+ staticDescriptor, JS_GET_NAME('CLASS_DESCRIPTOR_PROPERTY')),
+ true, result);
}
return result;
}
@@ -2685,7 +2689,10 @@
/// Returns true if the key represent ancillary reflection data, that is, not a
/// method.
bool isReflectiveDataInPrototype(String key) {
- if (key == '' || key == METHODS_WITH_OPTIONAL_ARGUMENTS) return true;
+ if (key == JS_GET_NAME('CLASS_DESCRIPTOR_PROPERTY') ||
+ key == METHODS_WITH_OPTIONAL_ARGUMENTS) {
+ return true;
+ }
String firstChar = key[0];
return firstChar == '*' || firstChar == '+';
}
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart ('k') | tools/VERSION » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698