Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 175043002: Don't ignore size updates that have a width and height == 0. (Closed)

Created:
6 years, 10 months ago by mkosiba (inactive)
Modified:
6 years, 10 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Don't ignore size updates that have a width and height == 0. It is perfectly legal for the Android WebView to have a zero height, this is frequenly how a new WebView is first laid out. Rejecting the initial (width, 0) size update causes the initial layout to be too narrow. BUG=344885 TBR=aelias@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167594

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M Source/web/WebViewImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mkosiba (inactive)
This is a re-land of https://codereview.chromium.org/172203003/. The original CL was reverted because the newly added ...
6 years, 10 months ago (2014-02-21 11:37:16 UTC) #1
mnaganov (inactive)
On 2014/02/21 11:37:16, mkosiba wrote: > This is a re-land of https://codereview.chromium.org/172203003/. The original CL ...
6 years, 10 months ago (2014-02-21 11:46:55 UTC) #2
mkosiba (inactive)
The CQ bit was checked by mkosiba@chromium.org
6 years, 10 months ago (2014-02-21 12:00:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/175043002/1
6 years, 10 months ago (2014-02-21 12:00:32 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 13:10:59 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=13527
6 years, 10 months ago (2014-02-21 13:11:00 UTC) #6
mkosiba (inactive)
The CQ bit was checked by mkosiba@chromium.org
6 years, 10 months ago (2014-02-21 13:43:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/175043002/1
6 years, 10 months ago (2014-02-21 13:43:51 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 13:44:10 UTC) #9
Message was sent while issue was closed.
Change committed as 167594

Powered by Google App Engine
This is Rietveld 408576698