Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: media/audio/mac/audio_low_latency_input_mac.cc

Issue 1750403004: Adds Media.Audio.InputStartWasDeferredAudioWorkedMac UMA stat (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/mac/audio_low_latency_input_mac.cc
diff --git a/media/audio/mac/audio_low_latency_input_mac.cc b/media/audio/mac/audio_low_latency_input_mac.cc
index 131ff7269bad619b75c7ebe725d3cefcfb612ab8..1aa4ae4a500c0d3d864ddedfe6fc1765b4f874b1 100644
--- a/media/audio/mac/audio_low_latency_input_mac.cc
+++ b/media/audio/mac/audio_low_latency_input_mac.cc
@@ -560,6 +560,16 @@ void AUAudioInputStream::Close() {
// selected set of the |device_property_changes_map_| map. Add UMA stats
// if valuable data is found.
AddDevicePropertyChangesToUMA(false);
+ // Log whether call to Start() was deferred or not. To be compared with
+ // Media.Audio.InputStartWasDeferredMac which logs the same value but only
+ // when input audio fails to start.
+ UMA_HISTOGRAM_BOOLEAN("Media.Audio.InputStartWasDeferredAudioWorkedMac",
+ start_was_deferred_);
+ // Log if a change of I/O buffer size was required. To be compared with
+ // Media.Audio.InputBufferSizeWasChangedMac which logs the same value but
+ // only when input audio fails to start.
+ UMA_HISTOGRAM_BOOLEAN("Media.Audio.InputBufferSizeWasChangedAudioWorkedMac",
+ buffer_size_was_changed_);
// TODO(henrika): possibly add more values here...
}
// Inform the audio manager that we have been closed. This will cause our
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698