Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 175040: More Mac layout test expectations verification (Closed)

Created:
11 years, 3 months ago by Paul Godavari
Modified:
9 years, 7 months ago
Reviewers:
ojan
CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org
Visibility:
Public.

Description

More Mac layout test expectations verification. Make the state of Mac Layout/http tests reflect reality by removing blanket exceptions and adding in specific failures. BUG=20442 TEST=Covered by layout tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25008

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M webkit/tools/layout_tests/test_expectations.txt View 1 2 4 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Godavari
Note: only tested on the debug layout_mac tryserver, so there may be some redness on ...
11 years, 3 months ago (2009-09-01 01:24:31 UTC) #1
ojan
11 years, 3 months ago (2009-09-01 01:27:50 UTC) #2
LGTM. Please remember to close any bugs whose listings you totally remove
from the file.

On Mon, Aug 31, 2009 at 6:24 PM, <paul@chromium.org> wrote:

> Reviewers: ojan,
>
> Message:
> Note: only tested on the debug layout_mac tryserver, so there may be
> some redness on the release webkit builder.
>
> Description:
> More Mac layout test expectations verification.
>
> Make the state of Mac Layout/http tests reflect reality by
> removing blanket exceptions and adding in specific failures.
>
> BUG=20442
> TEST=Covered by layout tests.
>
>
> Please review this at http://codereview.chromium.org/175040
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     webkit/tools/layout_tests/test_expectations.txt
>
>
> Index: webkit/tools/layout_tests/test_expectations.txt
> ===================================================================
> --- webkit/tools/layout_tests/test_expectations.txt     (revision 24969)
> +++ webkit/tools/layout_tests/test_expectations.txt     (working copy)
> @@ -1501,13 +1501,6 @@
>  BUG10382 MAC :
> LayoutTests/transitions/change-values-during-transition.html = FAIL PASS
>  BUG10382 MAC : LayoutTests/transitions/shorthand-border-transitions.html =
> FAIL PASS
>
> -// Most of the http tests seem to be flaky on the mac.
> -// Don't mark these as FAIL since we want to know if tests start failing.
> -// TODO(ojan): Remove all the mac http tests that are now redundant with
> the
> -// following two lines.
> -BUG10383 MAC : LayoutTests/http = CRASH TIMEOUT PASS
> -BUG10672 MAC : chrome/http = PASS CRASH TIMEOUT
> -
>  // The following are flaky in that some times the timeout or crash, but we
> think
>  // it is because of bugs in other parts of the code and not specific to
> what
>  // these tests are doing.  The are being noted here so we can get the
> buildbots
> @@ -2436,7 +2429,7 @@
>  BUG20341 : LayoutTests/loader/go-back-to-different-window-size.html =
> TIMEOUT
>
>  // WebKit 47732:47748.
> -BUG20324 WIN LINUX :
> LayoutTests/http/tests/security/javascriptURL/javascriptURL-in-new-iframe.html
> = CRASH
> +BUG20324 :
> LayoutTests/http/tests/security/javascriptURL/javascriptURL-in-new-iframe.html
> = CRASH
>
>  // WebKit 47748:47759. Crash only on Linux. Need investigation.
>  BUG20265 LINUX : LayoutTests/fast/css/pseudo-required-optional-005.html =
> CRASH
> @@ -2449,7 +2442,7 @@
>  BUG20345 : LayoutTests/fast/js/getOwnPropertyDescriptor.html = FAIL
>
>  // Webkit 47790:47797
> -BUG20356 LINUX WIN :
> LayoutTests/http/tests/xmlhttprequest/cross-origin-cookie-storage.html =
> TIMEOUT
> +BUG20356 :
> LayoutTests/http/tests/xmlhttprequest/cross-origin-cookie-storage.html =
> TIMEOUT
>
>  // WebKit 47797:47804
>  BUG20376 WIN : LayoutTests/media/audio-play-event.html = TIMEOUT
> @@ -2467,3 +2460,9 @@
>  // This newly added test times out on Mac:
>  BUG20438 MAC : chrome/plugins/get-url-with-iframe-target.html = TIMEOUT
>  BUG20438 MAC : chrome/plugins/get-url-with-iframe-target-no-crash.html =
> TIMEOUT
> +
> +// Mac LayoutTest/http errors after removing blanket exception.
> +BUG20748 MAC : LayoutTests/http/tests/plugins/npapi-response-headers.html
> = TIMEOUT
> +BUG20748 MAC :
>
LayoutTests/http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html
> = TIMEOUT
> +BUG20748 MAC : LayoutTests/http/tests/plugins/get-url.html = TIMEOUT
> +BUG20748 MAC : LayoutTests/http/tests/plugins/interrupted-get-url.html =
> TIMEOUT
>
>
>

Powered by Google App Engine
This is Rietveld 408576698