Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 1750393003: Replaced apk_command_line with adb_cast_shell_command_line. (Closed)

Created:
4 years, 9 months ago by sanfin
Modified:
4 years, 9 months ago
Reviewers:
halliwell, Simeon, agrieve
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, jbudorick+watch_chromium.org, halliwell+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replaced apk_command_line with adb_cast_shell_command_line. The new script uses the adb_command_line.py script in build/android and is therefore compatible with the --device argument. BUG= internal b/26406816 Committed: https://crrev.com/24d7960decb02198c73a9fcd3e847de8e97702fe Cr-Commit-Position: refs/heads/master@{#378780}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -37 lines) Patch
A build/android/adb_cast_shell_command_line View 1 1 chunk +22 lines, -0 lines 0 comments Download
M build/android/adb_command_line.py View 2 chunks +3 lines, -1 line 0 comments Download
D chromecast/tools/apk_command_line View 1 chunk +0 lines, -36 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Simeon
4 years, 9 months ago (2016-03-02 00:27:19 UTC) #4
agrieve
lgtm https://codereview.chromium.org/1750393003/diff/1/build/android/adb_cast_shell_command_line File build/android/adb_cast_shell_command_line (right): https://codereview.chromium.org/1750393003/diff/1/build/android/adb_cast_shell_command_line#newcode3 build/android/adb_cast_shell_command_line:3: # Copyright 2014 The Chromium Authors. All rights ...
4 years, 9 months ago (2016-03-02 02:39:35 UTC) #5
halliwell
On 2016/03/02 02:39:35, agrieve wrote: > lgtm > > https://codereview.chromium.org/1750393003/diff/1/build/android/adb_cast_shell_command_line > File build/android/adb_cast_shell_command_line (right): > ...
4 years, 9 months ago (2016-03-02 02:42:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750393003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750393003/20001
4 years, 9 months ago (2016-03-02 17:08:13 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-02 18:32:18 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 18:33:13 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/24d7960decb02198c73a9fcd3e847de8e97702fe
Cr-Commit-Position: refs/heads/master@{#378780}

Powered by Google App Engine
This is Rietveld 408576698