Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: tests/compiler/dart2js/sourcemaps/diff_view.dart

Issue 1750393002: Add --use-new-source-info option (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/sourcemaps/diff_view.dart
diff --git a/tests/compiler/dart2js/sourcemaps/diff_view.dart b/tests/compiler/dart2js/sourcemaps/diff_view.dart
index c58a21edaddaa94eb75f99cb5963b52b54bce5c8..28e76330c31ae919377a9e607b164a9c6fb9d9c2 100644
--- a/tests/compiler/dart2js/sourcemaps/diff_view.dart
+++ b/tests/compiler/dart2js/sourcemaps/diff_view.dart
@@ -71,8 +71,9 @@ main(List<String> args) async {
if (optionSegments.length == 1) {
// Use default options; comparing SSA and CPS output using the new
// source information strategy.
- options.add([USE_NEW_SOURCE_INFO]..addAll(commonArguments));
- options.add([USE_NEW_SOURCE_INFO, Flags.useCpsIr]..addAll(commonArguments));
+ options.add([Flags.useNewSourceInfo]..addAll(commonArguments));
+ options.add(
+ [Flags.useNewSourceInfo, Flags.useCpsIr]..addAll(commonArguments));
} else if (optionSegments.length == 2) {
// Use alternative options for the second output column.
options.add(commonArguments);
@@ -459,7 +460,7 @@ Future<CodeLinesResult> computeCodeLines(
String title = '${step.id}:${step.kind}:${step.offset}';
if (!addSourceLocationsForNode(WITH_SOURCE_INFO, step.node, title)) {
int offset;
- if (options.contains(USE_NEW_SOURCE_INFO)) {
+ if (options.contains(Flags.useNewSourceInfo)) {
offset = step.offset.subexpressionOffset;
} else {
offset = info.jsCodePositions[step.node].startPosition;
« no previous file with comments | « pkg/compiler/lib/src/js_backend/js_backend.dart ('k') | tests/compiler/dart2js/sourcemaps/sourcemap_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698