Progress on gamma-correctness in the GPU backend. Fixed conversion of color and profile type to pix…

Added (color=8888|f16|srgb) option to gpu configurations, along with gpuf16 and gpusrgb predefined configs. Runs the gpu backend in gamma-correct mode (with either FP16 linear or sRGB 8888 frambuffers).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1750383002

Committed: https://skia.googlesource.com/skia/+/a6f58194733c1c50e4fe5f98585e42344f29b6f0

Committed: https://skia.googlesource.com/skia/+/d93c1208520376ec062c8e9b6b7e6d0eac6c6faf

[Brian Osman, 2016-03-01 15:01:00]

Description was changed from

==========
Progress on gamma-correctness in the GPU backend. Fixed conversion of color and
profile type to pixel config, which makes many things "just work".

Added (color=8888|f16|srgb) option to gpu configurations, along with gpuf16,
gpusrgb, and anglesrgb predefined configs. Runs the gpu backend in gamma-correct
mode (with either FP16 linear or sRGB 8888 frambuffers).

BUG=skia:
==========

to

==========
Progress on gamma-correctness in the GPU backend. Fixed conversion of color and
profile type to pixel config, which makes many things "just work".

Added (color=8888|f16|srgb) option to gpu configurations, along with gpuf16,
gpusrgb, and anglesrgb predefined configs. Runs the gpu backend in gamma-correct
mode (with either FP16 linear or sRGB 8888 frambuffers).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Brian Osman, 2016-03-01 15:03:21]

brianosman@google.com changed reviewers:
+ bsalomon@google.com, mtklein@google.com

[Brian Osman, 2016-03-01 15:03:21]

Couldn't figure out how to re-open/CQ the reverted version from yesterday. This
is the same change, minus the kRGBA stuff (we are back to using kN32 when making
the GPU resources). I was able to repro the DM failure locally, and that fixed
it. Also double-checking with trybots before sending to CQ this time.

[bsalomon, 2016-03-01 15:43:52]

lgtm

[mtklein, 2016-03-01 16:22:26]

On 2016/03/01 15:03:21, Brian Osman wrote:
> Couldn't figure out how to re-open/CQ the reverted version from yesterday.
This
> is the same change, minus the kRGBA stuff (we are back to using kN32 when
making
> the GPU resources). I was able to repro the DM failure locally, and that fixed
> it. Also double-checking with trybots before sending to CQ this time.

To re-open the previous CL, click the "Edit issue" link in the top left of its
main codereview page.  Then untick the Closed check box.

You can upload new patchsets to it by

$ git cl patch 1746253002
$ hack; hack; hack
$ git commit -am 'next patch set'
$ git cl upload - t 'next patch set'

or if you've already got something going, just do

$ git cl issue 1746253002
$ git cl upload -t 'next patch set'

[Brian Osman, 2016-03-01 20:23:21]

The CQ bit was checked by brianosman@google.com

[commit-bot: I haz the power, 2016-03-01 20:23:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1750383002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1750383002/1

[commit-bot: I haz the power, 2016-03-01 20:53:09]

Description was changed from

==========
Progress on gamma-correctness in the GPU backend. Fixed conversion of color and
profile type to pixel config, which makes many things "just work".

Added (color=8888|f16|srgb) option to gpu configurations, along with gpuf16,
gpusrgb, and anglesrgb predefined configs. Runs the gpu backend in gamma-correct
mode (with either FP16 linear or sRGB 8888 frambuffers).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Progress on gamma-correctness in the GPU backend. Fixed conversion of color and
profile type to pixel config, which makes many things "just work".

Added (color=8888|f16|srgb) option to gpu configurations, along with gpuf16,
gpusrgb, and anglesrgb predefined configs. Runs the gpu backend in gamma-correct
mode (with either FP16 linear or sRGB 8888 frambuffers).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/a6f58194733c1c50e4fe5f98585e42344f29b6f0
==========

[commit-bot: I haz the power, 2016-03-01 20:53:09]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a6f58194733c1c50e4fe5f98585e42344f29b6f0

[Brian Osman, 2016-03-01 21:44:04]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1755553003/ by brianosman@google.com.

The reason for reverting is: GM breakage. Changes to SkGr.cpp appear to be
altering behavior on a variety of tests. Debugging....

[Brian Osman, 2016-03-01 22:01:01]

https://codereview.chromium.org/1750383002/diff/1/src/gpu/SkGr.cpp
File src/gpu/SkGr.cpp (right):

https://codereview.chromium.org/1750383002/diff/1/src/gpu/SkGr.cpp#newcode378
src/gpu/SkGr.cpp:378: ? kSRGBA_8888_GrPixelConfig // Does not preserve byte
order!
Given all the Red/Blue swap failures I'm seeing after landing this (eg
https://gold.skia.org/search2?blame=eef980270d3385fee340eb1633962fe3ba8b7132&...),
it looks like we might need to handle sBGRA. Sigh.

[Brian Osman, 2016-03-09 21:23:09]

Description was changed from

==========
Progress on gamma-correctness in the GPU backend. Fixed conversion of color and
profile type to pixel config, which makes many things "just work".

Added (color=8888|f16|srgb) option to gpu configurations, along with gpuf16,
gpusrgb, and anglesrgb predefined configs. Runs the gpu backend in gamma-correct
mode (with either FP16 linear or sRGB 8888 frambuffers).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/a6f58194733c1c50e4fe5f98585e42344f29b6f0
==========

to

==========
Added (color=8888|f16|srgb) option to gpu configurations, along with gpuf16,
gpusrgb, and anglesrgb predefined configs. Runs the gpu backend in gamma-correct
mode (with either FP16 linear or sRGB 8888 frambuffers).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/a6f58194733c1c50e4fe5f98585e42344f29b6f0
==========

[Brian Osman, 2016-03-09 21:32:39]

Just trying to get the DM configuration stuff landed, separately from any
back-end changes that will alter output. This will also make it easier to diff
DM output of various sRGB changes I have going.

https://codereview.chromium.org/1750383002/diff/20001/tools/flags/SkCommonFla...
File tools/flags/SkCommonFlagsConfig.cpp (right):

https://codereview.chromium.org/1750383002/diff/20001/tools/flags/SkCommonFla...
tools/flags/SkCommonFlagsConfig.cpp:258: *outColorType = kN32_SkColorType;
If we decide that sRGB implies RGBA, this is where we'd enforce that. For now, I
just want to get some version of this test harness landed to decouple it from
other changes on my branch(es).

[Brian Osman, 2016-03-09 21:46:39]

Description was changed from

==========
Added (color=8888|f16|srgb) option to gpu configurations, along with gpuf16,
gpusrgb, and anglesrgb predefined configs. Runs the gpu backend in gamma-correct
mode (with either FP16 linear or sRGB 8888 frambuffers).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/a6f58194733c1c50e4fe5f98585e42344f29b6f0
==========

to

==========
Added (color=8888|f16|srgb) option to gpu configurations, along with gpuf16 and
gpusrgb predefined configs. Runs the gpu backend in gamma-correct mode (with
either FP16 linear or sRGB 8888 frambuffers).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/a6f58194733c1c50e4fe5f98585e42344f29b6f0
==========

[Brian Osman, 2016-03-10 15:30:26]

The CQ bit was checked by brianosman@google.com

[Brian Osman, 2016-03-10 15:30:26]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1750383002/#ps40001
(title: "Remove ANGLE sRGB, which isn't going to be supported in the near
term.")

[commit-bot: I haz the power, 2016-03-10 15:30:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1750383002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1750383002/40001

[commit-bot: I haz the power, 2016-03-10 15:49:11]

Description was changed from

==========
Added (color=8888|f16|srgb) option to gpu configurations, along with gpuf16 and
gpusrgb predefined configs. Runs the gpu backend in gamma-correct mode (with
either FP16 linear or sRGB 8888 frambuffers).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/a6f58194733c1c50e4fe5f98585e42344f29b6f0
==========

to

==========
Added (color=8888|f16|srgb) option to gpu configurations, along with gpuf16 and
gpusrgb predefined configs. Runs the gpu backend in gamma-correct mode (with
either FP16 linear or sRGB 8888 frambuffers).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/a6f58194733c1c50e4fe5f98585e42344f29b6f0

Committed:
https://skia.googlesource.com/skia/+/d93c1208520376ec062c8e9b6b7e6d0eac6c6faf
==========

[commit-bot: I haz the power, 2016-03-10 15:49:12]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/d93c1208520376ec062c8e9b6b7e6d0eac6c6faf