Description[Interpreter] Fixes PushArgsAndConstruct builtin to not store any data outside esp.
In ia32 PushArgsAndConstruct builtin, we run out of registers and need to
temporarily store the data in the stack. In the earlier implementation,
a location outside the esp was used. This causes a problem if there is a
interrupt/signals which would use the same stack and corrupt the data that
is above the esp. This cl fixes it by pushing it onto the stack so that
the stack pointer is updated and hence the corruption will not happen. We
reuse the slot meant for receiver as a temporary store.
TBR=rmcilroy@chromium.org
BUG=v8:4280
LOG=N
Committed: https://crrev.com/dbf5fffd2d58289fcb05c0ac7dde40c76dfa9472
Cr-Commit-Position: refs/heads/master@{#34397}
Patch Set 1 #
Messages
Total messages: 11 (6 generated)
|