Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Issue 1750373002: [Interpreter] Fixes PushArgsAndConstruct builtin to not store any data outside esp. (Closed)

Created:
4 years, 9 months ago by mythria
Modified:
4 years, 9 months ago
Reviewers:
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Fixes PushArgsAndConstruct builtin to not store any data outside esp. In ia32 PushArgsAndConstruct builtin, we run out of registers and need to temporarily store the data in the stack. In the earlier implementation, a location outside the esp was used. This causes a problem if there is a interrupt/signals which would use the same stack and corrupt the data that is above the esp. This cl fixes it by pushing it onto the stack so that the stack pointer is updated and hence the corruption will not happen. We reuse the slot meant for receiver as a temporary store. TBR=rmcilroy@chromium.org BUG=v8:4280 LOG=N Committed: https://crrev.com/dbf5fffd2d58289fcb05c0ac7dde40c76dfa9472 Cr-Commit-Position: refs/heads/master@{#34397}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -17 lines) Patch
M src/ia32/builtins-ia32.cc View 1 chunk +12 lines, -15 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750373002/1
4 years, 9 months ago (2016-03-01 14:51:23 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-01 15:15:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750373002/1
4 years, 9 months ago (2016-03-01 15:17:14 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 15:19:30 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 15:20:15 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dbf5fffd2d58289fcb05c0ac7dde40c76dfa9472
Cr-Commit-Position: refs/heads/master@{#34397}

Powered by Google App Engine
This is Rietveld 408576698