content/browser/service_worker/service_worker_url_request_job.cc - Issue 1750333002: Reland of Pipe response_time from FetchManager to CacheStorage and ServiceWorkerURLRequestJob.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_url_request_job.cc

Issue 1750333002: Reland of Pipe response_time from FetchManager to CacheStorage and ServiceWorkerURLRequestJob. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_browsertest.cc ('k') | content/browser/service_worker/service_worker_url_request_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_url_request_job.cc

diff --git a/content/browser/service_worker/service_worker_url_request_job.cc b/content/browser/service_worker/service_worker_url_request_job.cc

index b5b97f2a58b2b0ee2e9831fd3e06a30cfbe2f6be..092d72dbfad736e14f53cff047e7e9406729c943 100644

--- a/content/browser/service_worker/service_worker_url_request_job.cc

+++ b/content/browser/service_worker/service_worker_url_request_job.cc

@@ -310,7 +310,8 @@

void ServiceWorkerURLRequestJob::OnResponseStarted(net::URLRequest* request) {

// TODO(falken): Add Content-Length, Content-Type if they were not provided in

// the ServiceWorkerResponse.

- response_time_ = base::Time::Now();

+ if (response_time_.is_null())

+ response_time_ = base::Time::Now();

CommitResponseHeader();

}

@@ -663,6 +664,7 @@

streaming_version_->AddStreamingURLRequestJob(this);

response_url_ = response.url;

service_worker_response_type_ = response.response_type;

+ response_time_ = response.response_time;

CreateResponseHeader(

response.status_code, response.status_text, response.headers);

load_timing_info_.receive_headers_end = base::TimeTicks::Now();