third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js - Issue 1750263002: Devtools: Do not greedily collapse URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

Issue 1750263002: Devtools: Do not greedily collapse URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/inspector/elements/styles/url-multiple-collapsing.html ('K') | « third_party/WebKit/LayoutTests/inspector/elements/styles/url-multiple-collapsing-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

index 51fb7a1c50ddc9df280bbe8b90b9cf222ea66d65..e8a61800be7a17010986138a5a37124a32a31a6c 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

@@ -2989,9 +2989,9 @@ WebInspector.StylesSidebarPropertyRenderer._urlRegex = function(value)

{

// Heuristically choose between single-quoted, double-quoted or plain URL regex.

if (/url\(\s*'.*\s*'\s*\)/.test(value))

- return /url\(\s*('.+')\s*\)/g;

+ return /url\(\s*('.+?')\s*\)/g;

if (/url\(\s*".*\s*"\s*\)/.test(value))

- return /url\(\s*(".+")\s*\)/g;

+ return /url\(\s*(".+?")\s*\)/g;

return /url\(\s*([^)]+)\s*\)/g;

}