Chromium Code Reviews Chromium Code Reviews
Issue 1750263002:
Devtools: Do not greedily collapse URLs (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/LayoutTests/inspector/elements/styles/url-multiple-collapsing.html |
| diff --git a/third_party/WebKit/LayoutTests/inspector/elements/styles/url-color-swatch.html b/third_party/WebKit/LayoutTests/inspector/elements/styles/url-multiple-collapsing.html |
| similarity index 70% |
| copy from third_party/WebKit/LayoutTests/inspector/elements/styles/url-color-swatch.html |
| copy to third_party/WebKit/LayoutTests/inspector/elements/styles/url-multiple-collapsing.html |
| index b0647df0c60769b38c8a2ce17bc755dc70d92d7e..ff241e6e8e6c0304d6a23612443f0c044be9c5c7 100644 |
| --- a/third_party/WebKit/LayoutTests/inspector/elements/styles/url-color-swatch.html |
| +++ b/third_party/WebKit/LayoutTests/inspector/elements/styles/url-multiple-collapsing.html |
| @@ -2,7 +2,7 @@ |
| <head> |
| <style> |
| #inspected { |
| - background-image: url("red green blue.jpg"); |
| + background: -webkit-image-set(url("chrome-search://theme/IDR_THEME_NTP_BACKGROUND?pfncmbjabnpldlfbnmhnhblapoibfbei") 1x, url("chrome-search://theme/IDR_THEME_NTP_BACKGROUND@2x?pfncmbjabnpldlfbnmhnhblapoibfbei") 2x); |
| color: red; |
| } |
| </style> |
| @@ -16,8 +16,7 @@ function test() |
| function step1() |
| { |
| - dumpDOM(InspectorTest.getMatchedStylePropertyTreeItem("background-image")); |
| - dumpDOM(InspectorTest.getMatchedStylePropertyTreeItem("color")); |
| + dumpDOM(InspectorTest.getMatchedStylePropertyTreeItem("background")); |
| InspectorTest.completeTest(); |
| } |
| @@ -36,10 +35,7 @@ function test() |
| var node = childNodes[i]; |
| switch (node.nodeType) { |
| case Node.ELEMENT_NODE: |
| - if (node.getAttribute("is") === "color-swatch") |
| - result.push("[] " + node.textContent); |
| - else |
| - dumpNode(node, result); |
| + dumpNode(node, result); |
| break; |
| case Node.TEXT_NODE: |
| result.push(node.nodeValue); |
| @@ -53,7 +49,7 @@ function test() |
| </head> |
| <body onload="runTest()"> |
| <p> |
| -Tests that url(...) with space-delimited color names as filename segments do not contain color swatches. Bug <a href="http://bugs.webkit.org/show_bug.cgi?id=106770">106770</a>. |
| +Tests that multiple URLs which are long are not squashed into a single URL. Bug <a href="http://bugs.webkit.org/show_bug.cgi?id=590172">590172</a>. |
|
lushnikov
2016/03/03 05:05:41
bugs.webkit.org?..
|
| </p> |
| <div id="inspected"></div> |
| </body> |
