Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2253)

Unified Diff: chrome/browser/cocoa/status_bubble_mac.mm

Issue 175025: Add a bare-bones extension shelf that displays extension items on OS X. (Closed)
Patch Set: Merge ToT, address more comments Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/status_bubble_mac.h ('k') | chrome/browser/extensions/extension_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/status_bubble_mac.mm
diff --git a/chrome/browser/cocoa/status_bubble_mac.mm b/chrome/browser/cocoa/status_bubble_mac.mm
index 1f2ecfa9b5fb26f2502e4cac62711f19cca9681f..7b592c6c8135e060c83836342f03bc5e5db78fae 100644
--- a/chrome/browser/cocoa/status_bubble_mac.mm
+++ b/chrome/browser/cocoa/status_bubble_mac.mm
@@ -39,8 +39,7 @@ StatusBubbleMac::StatusBubbleMac(NSWindow* parent, id delegate)
delegate_(delegate),
window_(nil),
status_text_(nil),
- url_text_(nil),
- is_download_shelf_visible_(false) {
+ url_text_(nil) {
}
StatusBubbleMac::~StatusBubbleMac() {
@@ -127,12 +126,10 @@ void StatusBubbleMac::MouseMoved() {
NSRect window_frame = [window_ frame];
window_frame.origin = [parent_ frame].origin;
- // Adjust the position to sit on top of download shelf.
+ // Adjust the position to sit on top of download and extension shelves.
// |delegate_| can be nil during unit tests.
- if (is_download_shelf_visible_) {
- if ([delegate_ respondsToSelector:@selector(verticalOffsetForStatusBubble)])
- window_frame.origin.y += [delegate_ verticalOffsetForStatusBubble];
- }
+ if ([delegate_ respondsToSelector:@selector(verticalOffsetForStatusBubble)])
+ window_frame.origin.y += [delegate_ verticalOffsetForStatusBubble];
// Get the cursor position relative to the popup.
cursor_location.x -= NSMaxX(window_frame);
@@ -179,7 +176,6 @@ void StatusBubbleMac::MouseMoved() {
}
void StatusBubbleMac::UpdateDownloadShelfVisibility(bool visible) {
- is_download_shelf_visible_ = visible;
}
void StatusBubbleMac::Create() {
« no previous file with comments | « chrome/browser/cocoa/status_bubble_mac.h ('k') | chrome/browser/extensions/extension_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698