Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Issue 1750213004: Simplify mock web speech recognizer's "onend" handling. (Closed)

Created:
4 years, 9 months ago by sof
Modified:
4 years, 9 months ago
CC:
blink-reviews, chromium-reviews, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify mock web speech recognizer's "onend" handling. ..and fix a bug introduced by r378252 in the process, it assuming a different interpretation of speech recognizer handle equality than what's (reasonably) provided. i.e., handle the completion of a speech recognition via one task rather than two. R=tommi,jochen BUG=591298 Committed: https://crrev.com/a4566f392891932b136c79a31b71488d73768298 Cr-Commit-Position: refs/heads/master@{#379299}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -19 lines) Patch
M components/test_runner/mock_web_speech_recognizer.cc View 4 chunks +8 lines, -18 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/speech/scripted/speechrecognition-restart-onend.html View 1 chunk +22 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/speech/scripted/speechrecognition-restart-onend-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (12 generated)
sof
please take a look.
4 years, 9 months ago (2016-03-02 12:22:04 UTC) #4
tommi (sloooow) - chröme
lgtm
4 years, 9 months ago (2016-03-03 11:40:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750213004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750213004/1
4 years, 9 months ago (2016-03-03 12:09:27 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/152890)
4 years, 9 months ago (2016-03-03 12:19:07 UTC) #11
sof
jochen@: stamp of approval?
4 years, 9 months ago (2016-03-04 09:58:15 UTC) #13
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-04 13:02:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750213004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750213004/1
4 years, 9 months ago (2016-03-04 13:34:45 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 16:28:48 UTC) #19
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 16:30:09 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4566f392891932b136c79a31b71488d73768298
Cr-Commit-Position: refs/heads/master@{#379299}

Powered by Google App Engine
This is Rietveld 408576698