Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 9 months ago by sof Modified:
4 years, 9 months ago Reviewers:
jochen (gone - plz use gerrit), dmazzoni, tommi (sloooow) - chröme CC:
blink-reviews, chromium-reviews, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSimplify mock web speech recognizer's "onend" handling.
..and fix a bug introduced by r378252 in the process, it assuming
a different interpretation of speech recognizer handle equality than
what's (reasonably) provided.
i.e., handle the completion of a speech recognition via one
task rather than two.
R=tommi,jochen
BUG=591298
Committed: https://crrev.com/a4566f392891932b136c79a31b71488d73768298
Cr-Commit-Position: refs/heads/master@{#379299}
Patch Set 1 #
Created: 4 years, 9 months ago
Messages
Total messages: 21 (12 generated)
Description was changed from ========== Simplify onend handling for mock web speech recognizer. R= BUG=591298 ========== to ========== Simplify mock web speech recognizer's "onend" handling. ..and fix a bug introduced by r378252 in the process, it assuming a different interpretation of speech recognizer handle than what's (reasonably) provided. i.e., handle the completion of a speech recognition via one task rather than two. R= BUG=591298 ==========
Description was changed from ========== Simplify mock web speech recognizer's "onend" handling. ..and fix a bug introduced by r378252 in the process, it assuming a different interpretation of speech recognizer handle than what's (reasonably) provided. i.e., handle the completion of a speech recognition via one task rather than two. R= BUG=591298 ========== to ========== Simplify mock web speech recognizer's "onend" handling. ..and fix a bug introduced by r378252 in the process, it assuming a different interpretation of speech recognizer handles than what's (reasonably) provided. i.e., handle the completion of a speech recognition via one task rather than two. R= BUG=591298 ==========
sigbjornf@opera.com changed reviewers: + dmazzoni@chromium.org, tommi@chromium.org
please take a look.
Description was changed from ========== Simplify mock web speech recognizer's "onend" handling. ..and fix a bug introduced by r378252 in the process, it assuming a different interpretation of speech recognizer handles than what's (reasonably) provided. i.e., handle the completion of a speech recognition via one task rather than two. R= BUG=591298 ========== to ========== Simplify mock web speech recognizer's "onend" handling. ..and fix a bug introduced by r378252 in the process, it assuming a different interpretation of speech recognizer handle equality than what's (reasonably) provided. i.e., handle the completion of a speech recognition via one task rather than two. R= BUG=591298 ==========
lgtm
Description was changed from ========== Simplify mock web speech recognizer's "onend" handling. ..and fix a bug introduced by r378252 in the process, it assuming a different interpretation of speech recognizer handle equality than what's (reasonably) provided. i.e., handle the completion of a speech recognition via one task rather than two. R= BUG=591298 ========== to ========== Simplify mock web speech recognizer's "onend" handling. ..and fix a bug introduced by r378252 in the process, it assuming a different interpretation of speech recognizer handle equality than what's (reasonably) provided. i.e., handle the completion of a speech recognition via one task rather than two. R=tommi BUG=591298 ==========
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750213004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750213004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
sigbjornf@opera.com changed reviewers: + jochen@chromium.org
jochen@: stamp of approval?
lgtm
Description was changed from ========== Simplify mock web speech recognizer's "onend" handling. ..and fix a bug introduced by r378252 in the process, it assuming a different interpretation of speech recognizer handle equality than what's (reasonably) provided. i.e., handle the completion of a speech recognition via one task rather than two. R=tommi BUG=591298 ========== to ========== Simplify mock web speech recognizer's "onend" handling. ..and fix a bug introduced by r378252 in the process, it assuming a different interpretation of speech recognizer handle equality than what's (reasonably) provided. i.e., handle the completion of a speech recognition via one task rather than two. R=tommi,jochen BUG=591298 ==========
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750213004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750213004/1
Message was sent while issue was closed.
Description was changed from ========== Simplify mock web speech recognizer's "onend" handling. ..and fix a bug introduced by r378252 in the process, it assuming a different interpretation of speech recognizer handle equality than what's (reasonably) provided. i.e., handle the completion of a speech recognition via one task rather than two. R=tommi,jochen BUG=591298 ========== to ========== Simplify mock web speech recognizer's "onend" handling. ..and fix a bug introduced by r378252 in the process, it assuming a different interpretation of speech recognizer handle equality than what's (reasonably) provided. i.e., handle the completion of a speech recognition via one task rather than two. R=tommi,jochen BUG=591298 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Simplify mock web speech recognizer's "onend" handling. ..and fix a bug introduced by r378252 in the process, it assuming a different interpretation of speech recognizer handle equality than what's (reasonably) provided. i.e., handle the completion of a speech recognition via one task rather than two. R=tommi,jochen BUG=591298 ========== to ========== Simplify mock web speech recognizer's "onend" handling. ..and fix a bug introduced by r378252 in the process, it assuming a different interpretation of speech recognizer handle equality than what's (reasonably) provided. i.e., handle the completion of a speech recognition via one task rather than two. R=tommi,jochen BUG=591298 Committed: https://crrev.com/a4566f392891932b136c79a31b71488d73768298 Cr-Commit-Position: refs/heads/master@{#379299} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a4566f392891932b136c79a31b71488d73768298 Cr-Commit-Position: refs/heads/master@{#379299} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
