Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 1750213003: Revert of Add FontCache API for retrieving prioritized fallback fonts (Closed)

Created:
4 years, 9 months ago by drott
Modified:
4 years, 9 months ago
Reviewers:
kojii, wkorman, eae
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, vmpstr+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add FontCache API for retrieving prioritized fallback fonts (patchset #8 id:160001 of https://codereview.chromium.org/1615923004/ ) Reason for revert: This will have to be done differently to be compatible with Android, where we cannot search by family name. Original issue's description: > Add FontCache API for retrieving prioritized fallback fonts > > BUG=580536 > > Committed: https://crrev.com/49d9c1f5fc97e4cedb0518cc3dd40771d8a68bec > Cr-Commit-Position: refs/heads/master@{#373499} TBR=wkorman@chromium.org,eae@chromium.org,kojii@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=580536 Committed: https://crrev.com/8f6a88c155f34940a3e1cf9988aed089d37d96a1 Cr-Commit-Position: refs/heads/master@{#378529}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -183 lines) Patch
M third_party/WebKit/Source/platform/fonts/FontCache.h View 3 chunks +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontCache.cpp View 1 chunk +0 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontCacheTest.cpp View 1 chunk +0 lines, -49 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/mac/FontCacheMac.mm View 2 chunks +0 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp View 2 chunks +0 lines, -55 lines 0 comments Download

Messages

Total messages: 12 (1 generated)
drott
Created Revert of Add FontCache API for retrieving prioritized fallback fonts
4 years, 9 months ago (2016-03-01 16:22:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750213003/1
4 years, 9 months ago (2016-03-01 16:22:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750213003/1
4 years, 9 months ago (2016-03-01 16:31:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750213003/1
4 years, 9 months ago (2016-03-01 17:01:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750213003/1
4 years, 9 months ago (2016-03-01 17:31:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750213003/1
4 years, 9 months ago (2016-03-01 18:02:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750213003/1
4 years, 9 months ago (2016-03-01 18:32:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750213003/1
4 years, 9 months ago (2016-03-01 19:03:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750213003/1
4 years, 9 months ago (2016-03-01 19:31:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 19:42:50 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 19:44:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f6a88c155f34940a3e1cf9988aed089d37d96a1
Cr-Commit-Position: refs/heads/master@{#378529}

Powered by Google App Engine
This is Rietveld 408576698