Fix Android black frames from MSE config changes.

content/common/gpu/client/gpu_video_decode_accelerator_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/client/gpu_video_decode_accelerator_host.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "base/thread_task_runner_handle.h"
@@ skipping 226 matching lines @@
     int32_t picture_buffer_id) {
   DCHECK(CalledOnValidThread());
   if (client_)
     client_->DismissPictureBuffer(picture_buffer_id);
 }
 
 void GpuVideoDecodeAcceleratorHost::OnPictureReady(
     int32_t picture_buffer_id,
     int32_t bitstream_buffer_id,
     const gfx::Rect& visible_rect,
-    bool allow_overlay) {
+    bool allow_overlay,
+    bool size_changed) {

[liberato (no reviews please), 2016/03/05 08:51:00]

another option is to start sending 'int32_t flags'.  Picture would hold the
int32_t, and accessors (e.g., allow_overlay()) would check the right bit
instead.

it's okay like this too.

[chcunningham, 2016/03/08 03:19:36]

I like this idea. This will involve changing a lot of files so let me see if
John signs off on the high level approach first.. 

[chcunningham, 2016/03/08 22:19:12]

Decided not to make it int32. I started to feel bad for callers of allow_overlay
having to now call flags and bitmask. Then I stumbled upon this in WebRTC call
thats not even in this CL yet and decided I'd reached a breaking point

https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/m...

Basically, I don't want bring down the visibility of allow_overlay() just
because size_changed() is a little awkward. 

I've done your other proposal: make size_changed be just a setter and leave the
constructor as is (with size_changed defaulting to false). 

   DCHECK(CalledOnValidThread());
   if (!client_)
     return;
   media::Picture picture(picture_buffer_id, bitstream_buffer_id, visible_rect,
-                         allow_overlay);
+                         allow_overlay, size_changed);
   client_->PictureReady(picture);
 }
 
 void GpuVideoDecodeAcceleratorHost::OnFlushDone() {
   DCHECK(CalledOnValidThread());
   if (client_)
     client_->NotifyFlushDone();
 }
 
 void GpuVideoDecodeAcceleratorHost::OnResetDone() {
   DCHECK(CalledOnValidThread());
   if (client_)
     client_->NotifyResetDone();
 }
 
 void GpuVideoDecodeAcceleratorHost::OnNotifyError(uint32_t error) {
   DCHECK(CalledOnValidThread());
   if (!client_)
     return;
   weak_this_factory_.InvalidateWeakPtrs();
 
   // Client::NotifyError() may Destroy() |this|, so calling it needs to be the
   // last thing done on this stack!
   media::VideoDecodeAccelerator::Client* client = NULL;
   std::swap(client, client_);
   client->NotifyError(static_cast<media::VideoDecodeAccelerator::Error>(error));
 }
 
 }  // namespace content